Merged
Conversation
- Force `.jpg` or `.png` extensions for `CompressedImage` - Throw an exception otherwise - Remove image encoding fallbacks in `ImageHandler` and throw an exception if `cv_bridge` fails
hect95
force-pushed
the
remove-handler-format-fallbacks
branch
from
cc09e93 to
d6f9277
Compare
GreatAlexander
previously approved these changes
Mar 24, 2025
Member
GreatAlexander
left a comment
GreatAlexander
left a comment
There was a problem hiding this comment.
Very minor suggestions, it's up to you if we could do with slightly more specific std exceptions or not. Feel free to ignore, 
ros2_bag_exporter/include/rosbag2_exporter/handlers/compressed_image_handler.hpp
Outdated
Show resolved
Hide resolved
ros2_bag_exporter/include/rosbag2_exporter/handlers/pointcloud_handler.hpp
Outdated
Show resolved
Hide resolved
hect95
force-pushed
the
remove-handler-format-fallbacks
branch
from
94a3680 to
1c118df
Compare
GreatAlexander
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforce image extensions and remove encoding fallbacks
.jpgor.pngextensions forCompressedImageImageHandlerand throw an exceptionif
cv_bridgefailsEnsure only point cloud messages with
intensityfield are supportedThrow exception if messages exportation failed in
BagExporter