Fail fast on broken feeds, work around conveyal/r5#978 #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks @c-voulgaris for reporting this and thanks @mattwigway for the PR ! |
This was referenced Sep 12, 2025
Contributor
Author
|
Actually, let's hold off - I have a better idea for how to do this |
Contributor
Author
|
Closing in favor of #516. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conveyal/r5#978, we discovered that due to an unfortunate collocation of events if a feed is very broken, all trips will end up in one trip pattern, which makes routing fail. This works around that by failing fast if it detects that patterns have not been properly detected.
Reported by @c-voulgaris