Skip to content

Fail fast on broken feeds, work around conveyal/r5#978 #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattwigway wants to merge 2 commits into from
Closed

Fail fast on broken feeds, work around conveyal/r5#978 #514

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0fc6af
fail fast on broken feeds, work around conveyal/r5#978
mattwigway Sep 12, 2025
0b4daa4
suggest using validate_gtfs on bad feeds
mattwigway Sep 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions java-r5rcore/src/org/ipea/r5r/Network/TransitLayerWithShapes.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,15 @@ public void loadFromGtfs (GTFSFeed gtfs, TransitLayer.LoadLevel level) throws Du
throw new DuplicateFeedException(gtfs.feedId);
}

if (gtfs.patterns.isEmpty()) {
throw new IllegalArgumentException(
String.format(
"Feed %s has no patterns, which means it is either empty or contains errors. Consider using validate_gtfs from {gtfstools}.",
gtfs.feedId
)
);
}

// checksum feed and add to checksum cache
feedChecksums.put(gtfs.feedId, gtfs.checksum);

Expand Down