[HipdnnPlugin] Update build + APIs to conform to TheRock#20
Merged
AaronStGeorge merged 2 commits intoNov 20, 2025
Merged
Conversation
AaronStGeorge
force-pushed
the
add-hipdnn-plugin__with-fixes
branch
2 times, most recently
from
8f038f5 to
bbf5086
Compare
AaronStGeorge
changed the title
TheRock
AaronStGeorge
force-pushed
the
add-hipdnn-plugin__with-fixes
branch
from
c552088 to
484065e
Compare
This PR updates Fusilli's hipDNN plugin for inclusion in `TheRock`. - `TheRock` requires `find_package` vs `FetchContent` ([link](https://github.com/ROCm/TheRock/blob/main/docs/development/build_system.md)) - The latest `hipDNN` in `TheRock` includes breaking API changes in `hipDNN`, and a few CMake variables (such as `FUSILLI_PLUGIN_WARNING_COMPILE_OPTIONS`) that are no longer available.
AaronStGeorge
force-pushed
the
add-hipdnn-plugin__with-fixes
branch
from
484065e to
d06c06b
Compare
| // Fusilli plugin should not offer to compile and execute bach norm (yet). | ||
| std::array<int64_t, 5> engineIDs; | ||
| uint32_t numEngines = -1; | ||
| uint32_t numEngines = 10; |
Member
There was a problem hiding this comment.
What motivated this change?
Contributor
Author
There was a problem hiding this comment.
Signed conversion warning included in -Wall or -Wextra (not sure). Before it was max unsigned int, but anything besides the expected value should be fine 🤷♂️ .
sjain-stanford
approved these changes
Nov 20, 2025
sjain-stanford
left a comment
sjain-stanford
left a comment
Member
There was a problem hiding this comment.
LGTM besides a couple minor comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Fusilli's hipDNN plugin for inclusion in
TheRock.TheRockrequiresfind_packagevsFetchContent(link)hipDNNinTheRockincludes breaking API changes inhipDNN, and a few CMake variables (such asFUSILLI_PLUGIN_WARNING_COMPILE_OPTIONS) that are no longer available.