Delete LinalgExt::PackOp and LinalgExt::UnPackOp#23550
Merged
Conversation
Contributor
Author
|
okay, it looks like we can delete the IREE's pack/unpack ops after we land the upstream changes:
I'm working on the IREE change that retires the ops. |
hanhanW
changed the title
hanhanW
force-pushed
the
users/hanhanW/retire-linalg-ext-pack-unpack
branch
from
f9bbb23 to
f0acb3b
Compare
hanhanW
requested review from
Groverkss,
IanWood1,
MaheshRavishankar,
Max191 and
qedawkins
as code owners
Contributor
Author
|
Oh, I thought that my changes are propagated to IREE. It seems like the last one is not yet landed to IREE. |
Signed-off-by: hanhanW <hanhan0912@gmail.com>
Signed-off-by: hanhanW <hanhan0912@gmail.com>
hanhanW
force-pushed
the
users/hanhanW/retire-linalg-ext-pack-unpack
branch
from
f0acb3b to
6559bee
Compare
Collaborator
|
ok nice! |
MaheshRavishankar
approved these changes
Mar 9, 2026
Collaborator
MaheshRavishankar
left a comment
MaheshRavishankar
left a comment
There was a problem hiding this comment.
Looks good if tests pass!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the transformations are upstreamed, so we can retire the ops.
Fixes #20030
ci-extra: test_torch