Replaced ament_target_dependencies with target_link_lirabries#143
Merged
Conversation
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Contributor
Author
|
do you mind to take a look @skyegalaxy ? |
skyegalaxy
requested changes
Oct 1, 2025
Member
There was a problem hiding this comment.
@ahcorde - When building in CI and locally I'm getting the following include failures:
/home/smedeiros/SourceCode/rolling-ws-2/src/ros2/ros2-performance/composition_benchmark/apps/base_publisher_main.cpp:15:10: fatal error: performance_test_factory/factory.hpp: No such file or directory
15 | #include "performance_test_factory/factory.hpp"
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
/home/smedeiros/SourceCode/rolling-ws-2/src/ros2/ros2-performance/performance_test_examples/src/server_nodes_main.cpp:15:10: fatal error: cxxopts.hpp: No such file or directory
15 | #include "cxxopts.hpp"
| ^~~~~~~~~~~~~
compilation terminated.
Member
|
@ahcorde - I PR'd one commit to this branch which adds the missing headers from before. once we merge it here we should be able to rerun CI and get this PR merged. |
skyegalaxy
reviewed
Feb 20, 2026
skyegalaxy
force-pushed
the
ahcorde/rolling/ament_target_dependencies_replaced_target_link_libraries
branch
2 times, most recently
from
65124c2 to
ebd1cb2
Compare
Member
|
I'll figure out separately why CI is not working, but I'm able to build this branch locally so I'll merge for now to unblock future rolling benchmarks |
skyegalaxy
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ament_target_dependenciesis deprecated and it should be replaced withtarget_link_lirabries