-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[Newton] Optimizes performance for some environments #4206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AntoineRichard
merged 3 commits into
isaac-sim:dev/newton
from
AntoineRichard:antoiner/newton_perf_opt
Dec 17, 2025
Merged
[Newton] Optimizes performance for some environments #4206
AntoineRichard
merged 3 commits into
isaac-sim:dev/newton
from
AntoineRichard:antoiner/newton_perf_opt
Dec 17, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Greptile OverviewGreptile SummaryThis PR implements performance optimizations for the Newton physics solver across multiple robot configurations and environment setups, yielding significant FPS improvements at scale (4096-16384 environments). Key Changes:
Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Env as Environment
participant Robot as Robot Articulation
participant Solver as MJWarp Solver
participant Data as Robot Data
Note over Env,Solver: Performance-Optimized Reset Flow
Env->>Robot: reset(env_ids)
Robot->>Data: default_root_pose[env_ids]
Robot->>Data: default_root_vel[env_ids]
Data-->>Robot: pose (transform)
Data-->>Robot: velocity (spatial_vector)
Robot->>Robot: write_root_pose_to_sim()
Robot->>Robot: write_root_velocity_to_sim()
Robot->>Robot: write_joint_state_to_sim()
Note over Solver: Solver Config Changes
Solver->>Solver: ls_parallel=True
Solver->>Solver: integrator="implicit"
Solver->>Solver: Tuned njmax/nconmax/ls_iterations
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
18 files reviewed, no comments
Collaborator
Author
2078f74 to
92133eb
Compare
kellyguo11
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Description
Perf opt to get the following:



Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there