-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[Newton] Updates docs to include visualizer instructions #4228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Newton] Updates docs to include visualizer instructions #4228
Conversation
Greptile SummaryAdded comprehensive visualizer documentation for Newton beta 2, updated installation instructions to make Isaac Sim 5.1 optional, and removed Spot from supported environments list. Key Changes
Issues Found
Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant CLI as Command Line
participant SimCfg as SimulationCfg
participant OV as Omniverse Visualizer
participant Newton as Newton Visualizer
participant Rerun as Rerun Visualizer
User->>CLI: Run with --visualizer flag
CLI->>SimCfg: Parse visualizer arguments
alt Omniverse selected
SimCfg->>OV: Initialize with OVVisualizerCfg
OV->>OV: Create viewport
OV->>OV: Setup camera
OV->>OV: Enable markers/plots
end
alt Newton selected
SimCfg->>Newton: Initialize with NewtonVisualizerCfg
Newton->>Newton: Create OpenGL window
Newton->>Newton: Setup camera
Newton->>Newton: Enable physics debug visuals
end
alt Rerun selected
SimCfg->>Rerun: Initialize with RerunVisualizerCfg
Rerun->>Rerun: Start web server
Rerun->>Rerun: Setup recording (if enabled)
Rerun->>User: Launch browser viewer
end
loop Simulation Steps
SimCfg->>OV: Update visualization
SimCfg->>Newton: Update visualization
SimCfg->>Rerun: Stream data
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (2)
-
docs/source/features/visualization.rst, line 279 (link)syntax: 'complex' is mis-spelled as 'complex' but should be 'complexity'
-
docs/source/experimental-features/newton-physics-integration/limitations-and-known-bugs.rst, line 21 (link)style: Spot removed here but still appears in
training-environments.rst:26asIsaac-Velocity-Flat-Spot-v0. Check for consistency.
4 files reviewed, 2 comments
Signed-off-by: matthewtrepte <[email protected]>
Signed-off-by: matthewtrepte <[email protected]>
…ewtrepte/IsaacLab into feature/newton-beta2-docs-with-viz
| @@ -0,0 +1,281 @@ | |||
| Visualization | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we replace the existing https://isaac-sim.github.io/IsaacLab/main/source/experimental-features/newton-physics-integration/newton-visualizer.html with this file instead? the visualizers are not supported on main branch yet, so probably doesn't make sense to have this in the features section yet.
| - Pausing visualizers while they are not being used | ||
|
|
||
|
|
||
| Limitations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's also add the known issues on the cuda 999 error and broken CoM and Contact visualization
docs/source/experimental-features/newton-physics-integration/visualization.rst
Outdated
Show resolved
Hide resolved
…isualization.rst Signed-off-by: Kelly Guo <[email protected]>
53bded6
into
isaac-sim:feature/newton-beta2-docs
Description
Updates documentation for newton beta 2:
Visualizers instructions
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there