Skip to content

Conversation

@kellyguo11
Copy link
Contributor

Description

Switch rlgames to isaac sim hosted repo and hides the headless flag printout since it can cause confusion for non-OV visualizers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added the isaac-lab Related to Isaac Lab team label Dec 18, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 18, 2025

Greptile Summary

This PR makes two straightforward changes: switches the rl-games dependency from a personal fork (kellyguo11/rl_games) to the official Isaac Sim hosted repository (isaac-sim/rl_games), and comments out the headless flag printout to reduce confusion when using non-Omniverse visualizers like Rerun or Newton.

Key Changes:

  • Updated setup.py to point to isaac-sim/[email protected] (same commit hash as the old repo)
  • Commented out headless flag in console output in app_launcher.py:621

Note:

  • Documentation file docs/source/setup/installation/isaaclab_pip_installation.rst:65 still references the old kellyguo11/rl_games repository and should be updated for consistency

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk once documentation is updated
  • Both changes are simple and low-risk: the repository switch uses the same commit, and commenting out a print statement has no functional impact. Score of 4 (not 5) due to inconsistent documentation that should be updated
  • The documentation file docs/source/setup/installation/isaaclab_pip_installation.rst needs attention to update the old repository reference

Important Files Changed

Filename Overview
source/isaaclab/isaaclab/app/app_launcher.py Comments out headless flag printout to reduce confusion for non-Omniverse visualizers - clean change with no issues
source/isaaclab_rl/setup.py Switches rl-games dependency from personal fork to official isaac-sim repo - same branch/commit, but documentation needs update

Sequence Diagram

sequenceDiagram
    participant User
    participant AppLauncher
    participant Console
    participant Setup
    participant RLGames

    User->>AppLauncher: Launch app with --visualizer rerun/newton
    AppLauncher->>AppLauncher: _resolve_headless_settings()
    AppLauncher->>AppLauncher: Set _headless=True for non-OV visualizers
    AppLauncher->>AppLauncher: _save_config_to_settings_manager()
    AppLauncher->>Console: print visualizer info
    AppLauncher->>Console: print offscreen_render info
    Note over AppLauncher,Console: headless printout now commented out
    
    User->>Setup: Install RL dependencies
    Setup->>RLGames: pip install from isaac-sim/[email protected]
    Note over Setup,RLGames: Changed from kellyguo11/rl_games to official repo
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. source/isaaclab_rl/setup.py, line 44 (link)

    style: check that documentation is also updated

    docs/source/setup/installation/isaaclab_pip_installation.rst:65 still has kellyguo11/[email protected] - should match this change

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 18, 2025
@kellyguo11 kellyguo11 merged commit 076081a into isaac-sim:dev/newton Dec 18, 2025
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant