-
Notifications
You must be signed in to change notification settings - Fork 2.8k
[Newton] Updates dependencies to support ARM #4251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Greptile SummaryThis PR refactors dependency management to support ARM64 (aarch64/arm64) architectures alongside existing x86_64 support by migrating from runtime platform checks to PEP 508 environment markers. Key Changes:
Critical Issue: Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant pip
participant setup.py
participant Platform
User->>pip: pip install isaaclab/isaaclab_newton/isaaclab_rl
pip->>setup.py: Read setup.py
setup.py->>setup.py: Define INSTALL_REQUIRES list
setup.py->>setup.py: Append platform-specific deps with PEP 508 markers
Note over setup.py: SUPPORTED_ARCHS_ARM = "platform_machine in ('x86_64','AMD64','aarch64','arm64')"<br/>SUPPORTED_ARCHS = "platform_machine in ('x86_64','AMD64')"
pip->>Platform: Evaluate platform_system and platform_machine
Platform-->>pip: Return 'Linux' and 'aarch64' (ARM) or 'x86_64'
alt ARM64 Architecture (aarch64/arm64)
pip->>pip: Install pin-pink==3.1.0 ✓
pip->>pip: Install daqp==0.7.2 ✓
pip->>pip: Install usd-exchange>=2.1.0a3 ✓
pip->>pip: Skip dex-retargeting (x86_64 only)
pip->>pip: Skip usd-core (x86_64 only)
pip->>pip: Install onnxscript>=0.5 (with rsl-rl extra)
else x86_64/AMD64 Architecture
pip->>pip: Install pin-pink==3.1.0 ✓
pip->>pip: Install daqp==0.7.2 ✓
pip->>pip: Install dex-retargeting==0.5.0 ✓
pip->>pip: Install usd-core==25.05.0 ✓
pip->>pip: Install usd-exchange>=2.1.0a3 ✓
pip->>pip: Install onnxscript>=0.5 (with rsl-rl extra)
end
pip-->>User: Installation complete
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (3)
-
source/isaaclab/setup.py, line 57-58 (link)syntax: PEP 508 marker syntax issue: the
inoperator requires a tuple of quoted strings, not a single string with comma-separated values -
source/isaaclab_newton/setup.py, line 44-45 (link)syntax: PEP 508 marker syntax issue: the
inoperator requires a tuple of quoted strings, not a single string with comma-separated values -
source/isaaclab_newton/setup.py, line 47 (link)style: Incorrect comment - this dependency is not related to
pink_ik, it should reference USD functionality
3 files reviewed, 3 comments
Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
Description
Updates dependencies to support ARM systems and Spark.
Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there