Replaces Isaac Sim SimulationManager with IsaacLab SimulationManager #4475
Conversation
github-actions
bot
added
the
documentation
ooctipus
force-pushed
the
feature/simulation-manager
branch
from
2720041 to
6ac6ed4
Compare
AntoineRichard
left a comment
AntoineRichard
left a comment
There was a problem hiding this comment.
Intermediary review. I feel the code is a bit too convoluted at times. Let's sync on that.
There was a problem hiding this comment.
Should we remove the isaacsim_4_5 apps or do we plan on supporting those still?
There was a problem hiding this comment.
Should we remove the isaacsim_4_5 apps or do we plan on supporting those still?
| "isaacsim.core.cloner" = {} | ||
| "isaacsim.core.nodes" = {} | ||
| "isaacsim.core.simulation_manager" = {} | ||
| # "isaacsim.core.simulation_manager" = {} # Replaced by isaaclab.sim.simulation_manager |
There was a problem hiding this comment.
This can just be removed?
| "isaacsim.core.cloner" = {} | ||
| "isaacsim.core.nodes" = {} | ||
| "isaacsim.core.simulation_manager" = {} | ||
| # "isaacsim.core.simulation_manager" = {} # Replaced by isaaclab.sim.simulation_manager |
There was a problem hiding this comment.
This could be removed directly?
| ) | ||
| # register prim deletion callback | ||
| self._prim_deletion_callback_id = SimulationManager.register_callback( | ||
| self._prim_deletion_callback_id = PhysxManager.register_callback( |
There was a problem hiding this comment.
I think the callbacks should live in the simulation context. It's something that we could take a look at in an other PR.
There was a problem hiding this comment.
Let's not have that here. I understand that it was used for testing, but let's keep things pure PhysX for now.
There was a problem hiding this comment.
Let's not have that here
| # from .newton_manager import NewtonManager | ||
| # from .newton_manager_cfg import NewtonManagerCfg |
| # "NewtonManager", | ||
| # "NewtonManagerCfg", |
There was a problem hiding this comment.
In general let's try to have only things that we can use here.
4 participants
Description
Adds simulation manager that replaces Isaac sim simulation manager,
this is currently a draft, things are mostly working, but lacks clean up.