Skip to content

Reduce warnings #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AntoineRichard wants to merge 1 commit into
base: develop
Choose a base branch
from
+49 −0
Open

Reduce warnings #4522

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions source/isaaclab/isaaclab/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,10 @@

# Configure the module-level variables
__version__ = ISAACLAB_METADATA["package"]["version"]

# Configure deprecation warnings to show only once per session (regardless of call site)
# This prevents repeated warnings when deprecated properties are accessed from multiple locations
import warnings
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move import warnings to the top of the file with other imports (line 8-9) per PEP8 conventions

Suggested change
import warnings
import warnings

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


warnings.filterwarnings("once", category=DeprecationWarning, module=r"isaaclab.*")
warnings.filterwarnings("once", category=FutureWarning, module=r"isaaclab.*")
7 changes: 7 additions & 0 deletions source/isaaclab_assets/isaaclab_assets/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,12 @@
# Configure the module-level variables
__version__ = ISAACLAB_ASSETS_METADATA["package"]["version"]

# Configure deprecation warnings to show only once per session (regardless of call site)
# This prevents repeated warnings when deprecated properties are accessed from multiple locations
import warnings
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move import warnings to the top of the file with other imports (line 7-8) per PEP8 conventions

Suggested change
import warnings
import warnings

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


warnings.filterwarnings("once", category=DeprecationWarning, module=r"isaaclab_assets.*")
warnings.filterwarnings("once", category=FutureWarning, module=r"isaaclab_assets.*")

from .robots import *
from .sensors import *
7 changes: 7 additions & 0 deletions source/isaaclab_contrib/isaaclab_contrib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,3 +22,10 @@

# Configure the module-level variables
__version__ = ISAACLAB_CONTRIB_METADATA["package"]["version"]

# Configure deprecation warnings to show only once per session (regardless of call site)
# This prevents repeated warnings when deprecated properties are accessed from multiple locations
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move import warnings to the top of the file with other imports (line 6-10) per PEP8 conventions

Suggested change
# This prevents repeated warnings when deprecated properties are accessed from multiple locations
import warnings

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

import warnings

warnings.filterwarnings("once", category=DeprecationWarning, module=r"isaaclab_contrib.*")
warnings.filterwarnings("once", category=FutureWarning, module=r"isaaclab_contrib.*")
7 changes: 7 additions & 0 deletions source/isaaclab_mimic/isaaclab_mimic/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,10 @@
"""Package containing implementation of Isaac Lab Mimic data generation."""

__version__ = "1.0.0"

# Configure deprecation warnings to show only once per session (regardless of call site)
# This prevents repeated warnings when deprecated properties are accessed from multiple locations
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add import warnings at the top of the file per PEP8 conventions

Suggested change
# This prevents repeated warnings when deprecated properties are accessed from multiple locations
import warnings

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

import warnings

warnings.filterwarnings("once", category=DeprecationWarning, module=r"isaaclab_mimic.*")
warnings.filterwarnings("once", category=FutureWarning, module=r"isaaclab_mimic.*")
7 changes: 7 additions & 0 deletions source/isaaclab_physx/isaaclab_physx/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,12 @@
# Configure the module-level variables
__version__ = ISAACLAB_PHYSX_METADATA["package"]["version"]

# Configure deprecation warnings to show only once per session (regardless of call site)
# This prevents repeated warnings when deprecated properties are accessed from multiple locations
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move import warnings to the top of the file with other imports (line 6-9) per PEP8 conventions

Suggested change
# This prevents repeated warnings when deprecated properties are accessed from multiple locations
import warnings

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

import warnings

warnings.filterwarnings("once", category=DeprecationWarning, module=r"isaaclab_physx.*")
warnings.filterwarnings("once", category=FutureWarning, module=r"isaaclab_physx.*")

# Import sensors module for auto-registration with factory
from . import sensors # noqa: F401, E402
7 changes: 7 additions & 0 deletions source/isaaclab_rl/isaaclab_rl/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,10 @@
expect different input and output data structures, their wrapper classes are not compatible with each other.
Thus, they should always be used in conjunction with the respective learning framework.
"""

# Configure deprecation warnings to show only once per session (regardless of call site)
# This prevents repeated warnings when deprecated properties are accessed from multiple locations
import warnings
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add import warnings at the top of the file per PEP8 conventions

Suggested change
import warnings
import warnings

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!


warnings.filterwarnings("once", category=DeprecationWarning, module=r"isaaclab_rl.*")
warnings.filterwarnings("once", category=FutureWarning, module=r"isaaclab_rl.*")
7 changes: 7 additions & 0 deletions source/isaaclab_tasks/isaaclab_tasks/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,13 @@
# Configure the module-level variables
__version__ = ISAACLAB_TASKS_METADATA["package"]["version"]

# Configure deprecation warnings to show only once per session (regardless of call site)
# This prevents repeated warnings when deprecated properties are accessed from multiple locations
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move import warnings to the top of the file with other imports (line 6-10) per PEP8 conventions

Suggested change
# This prevents repeated warnings when deprecated properties are accessed from multiple locations
import warnings

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

import warnings

warnings.filterwarnings("once", category=DeprecationWarning, module=r"isaaclab_tasks.*")
warnings.filterwarnings("once", category=FutureWarning, module=r"isaaclab_tasks.*")

##
# Register Gym environments.
##
Expand Down
Loading