Skip to content

Remove Run Tests in Docker Container test logs group#6591

Open
mataylor-nvidia wants to merge 2 commits into
isaac-sim:developfrom
mataylor-nvidia:mataylor/fix-group-logs-run-tests
Open

Remove Run Tests in Docker Container test logs group#6591
mataylor-nvidia wants to merge 2 commits into
isaac-sim:developfrom
mataylor-nvidia:mataylor/fix-group-logs-run-tests

Conversation

@mataylor-nvidia

Copy link
Copy Markdown

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions Bot added bug Something isn't working infrastructure labels Jul 17, 2026
@greptile-apps

greptile-apps Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the GitHub Actions log group wrapping (::group::/::endgroup::) around the Docker container log streaming section in .github/actions/run-tests/action.yml. The container logs will now stream inline without being collapsed into a named group.

  • Removes ::group::Following Docker container logs and its matching ::endgroup:: from the Docker log-streaming block, leaving the surrounding "Copy results" group intact and balanced.

Confidence Score: 5/5

Safe to merge — removing the log group markers has no effect on test execution, result collection, or container lifecycle management.

The only change is deleting two echo statements that emit GitHub Actions log-grouping markers. The Docker container is still launched, logs are still streamed, the container is still awaited, and results are still copied. Nothing in the test execution path is altered.

No files require special attention.

Important Files Changed

Filename Overview
.github/actions/run-tests/action.yml Removes the ::group::/::endgroup:: markers that wrapped Docker container log streaming; no functional change to test execution or result collection.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant GHA as GitHub Actions Runner
    participant Docker as Docker Container
    participant Logs as CI Log Output

    GHA->>Docker: docker exec (run pytest)
    note over Logs: (no ::group:: marker now)
    GHA->>Logs: docker logs -f (background stream)
    Docker-->>GHA: container exits
    GHA->>Logs: kill log follower
    note over Logs: (no ::endgroup:: marker now)
    GHA->>Logs: ::group::Copy results
    GHA->>Docker: docker cp (copy test results)
    GHA->>Logs: ::endgroup::
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant GHA as GitHub Actions Runner
    participant Docker as Docker Container
    participant Logs as CI Log Output

    GHA->>Docker: docker exec (run pytest)
    note over Logs: (no ::group:: marker now)
    GHA->>Logs: docker logs -f (background stream)
    Docker-->>GHA: container exits
    GHA->>Logs: kill log follower
    note over Logs: (no ::endgroup:: marker now)
    GHA->>Logs: ::group::Copy results
    GHA->>Docker: docker cp (copy test results)
    GHA->>Logs: ::endgroup::
Loading

Reviews (1): Last reviewed commit: "remove group" | Re-trigger Greptile

@github-actions github-actions Bot added the isaac-lab Related to Isaac Lab team label Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working infrastructure isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants