-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Add background_color to CameraCfg for cross-backend solid color camera backgrounds #6594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mataylor-nvidia
wants to merge
7
commits into
isaac-sim:develop
Choose a base branch
from
mataylor-nvidia:mataylor/camera-background-color
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2a17d48
Add background_color to CameraCfg for cross-backend solid color backg…
mataylor-nvidia 1ecae9f
fix
mataylor-nvidia ddcb2c9
update
mataylor-nvidia 4b8da77
format
mataylor-nvidia 1ca652d
Add feature documentation
mataylor-nvidia 240e00c
fix newton color ordering
mataylor-nvidia 8ad108b
update
mataylor-nvidia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
source/isaaclab/changelog.d/mataylor-camera-background-color.minor.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added :attr:`~isaaclab.sensors.camera.CameraCfg.background_color` to | ||
| :class:`~isaaclab.sensors.camera.CameraCfg` as a unified cross-backend way to set the camera | ||
| background to a solid color. Accepts normalized RGB floats ``(r, g, b)`` in ``[0, 1]``; | ||
| defaults to ``None`` (each backend's original default background). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
source/isaaclab_newton/changelog.d/mataylor-camera-background-color.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added support for :attr:`~isaaclab.sensors.camera.CameraCfg.background_color` in | ||
| :class:`~isaaclab_newton.renderers.NewtonWarpRenderer`. When set, converts the normalized RGB | ||
| color to an ARGB clear color passed to ``SensorTiledCamera.ClearData`` on each render call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
source/isaaclab_ov/changelog.d/mataylor-camera-background-color.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added support for :attr:`~isaaclab.sensors.camera.CameraCfg.background_color` in | ||
| :class:`~isaaclab_ov.renderers.OVRTXRenderer`. When set, authors | ||
| ``omni:rtx:background:source:type = "color"`` and ``omni:rtx:background:source:color`` on the | ||
| USD render product instead of the default ``"domeLight"`` background. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
source/isaaclab_physx/changelog.d/mataylor-camera-background-color.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added support for :attr:`~isaaclab.sensors.camera.CameraCfg.background_color` in | ||
| :class:`~isaaclab_physx.renderers.IsaacRtxRenderer`. When set, applies | ||
| ``/rtx/background/source/type = 2`` (Color) and ``/rtx/background/source/color`` via the | ||
| settings manager during camera setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.