Fixes stale single-source references for dependency pins#6597
Fixes stale single-source references for dependency pins#6597myurasov-nv wants to merge 1 commit into
Conversation
The root pyproject.toml is the single source of truth for dependency pins, but three references to it have gone stale: - The wheel-builder comment referenced python_packages.toml, a manifest that no longer exists. - daily-compatibility.yml parsed [tool.isaaclab.versions] with a hand written regex; use tomllib for the same output with real TOML parsing. - The pip-installation docs claimed rl_games is not included in the wheel extras, but gen_pyproject.py expands the all extra with rl-games (from the isaac-sim git branch) along with Rerun, Mimic, and RLinf.
Greptile SummaryThis PR fixes three stale references that had drifted from the single-source-of-truth
Confidence Score: 5/5All three changes are safe to merge: two are comment/doc corrections and the third is a drop-in stdlib replacement with identical runtime output. The No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[pyproject.toml\nsingle source of truth] --> B[tool.isaaclab.versions]
A --> C[tool.isaaclab extras\nrl-games / all]
B --> D[daily-compatibility.yml\ntomllib parse]
D --> E[ovphysx / ovrtx pins\npassed to Docker build]
C --> F[gen_pyproject.py\nwheel builder]
F --> G[Generated wheel pyproject.toml\nincludes rl_games in all + rl-games]
G --> H[isaaclab_pip_installation.rst\nnow accurately documents\nall extra incl. RL-Games]
I[build.sh comment] -.->|was referencing| J[python_packages.toml\ndeleted file ❌]
I -->|now describes| K[actual copy step\napps/ + source/ ✅]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[pyproject.toml\nsingle source of truth] --> B[tool.isaaclab.versions]
A --> C[tool.isaaclab extras\nrl-games / all]
B --> D[daily-compatibility.yml\ntomllib parse]
D --> E[ovphysx / ovrtx pins\npassed to Docker build]
C --> F[gen_pyproject.py\nwheel builder]
F --> G[Generated wheel pyproject.toml\nincludes rl_games in all + rl-games]
G --> H[isaaclab_pip_installation.rst\nnow accurately documents\nall extra incl. RL-Games]
I[build.sh comment] -.->|was referencing| J[python_packages.toml\ndeleted file ❌]
I -->|now describes| K[actual copy step\napps/ + source/ ✅]
Reviews (1): Last reviewed commit: "Fix stale single-source references for d..." | Re-trigger Greptile |
Description
Fixes three references that drifted from the single-source-of-truth root
pyproject.toml: the wheel builder comment pointed atpython_packages.toml(removed long ago),daily-compatibility.ymlparsed[tool.isaaclab.versions]with a hand-written regex (nowtomllib, byte-identical output), and the pip-installation docs claimedrl_gamesis excluded from the wheel extras whilegen_pyproject.pyactually includes it inall/rl-games.python_packages.tomltomllibparseallextraReproduction
grep python_packages.toml -r .returns only the stale comment; no such file exists.python3 tools/wheel_builder/gen_pyproject.py pyproject.toml /tmp/p.toml 1.2.3 && grep rl-games /tmp/p.tomlshowsrl_gamesin therl-gamesandallextras, contradicting the docs note.tomllibsnippets againstpyproject.toml: identical output.Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there