Skip to content

Update Newton FPGS non-WIP pin#6601

Merged
ooctipus merged 1 commit into
isaac-sim:fpgs-devfrom
ooctipus:ooctipus/fpgs-non-wip-pin-20260718
Jul 18, 2026
Merged

Update Newton FPGS non-WIP pin#6601
ooctipus merged 1 commit into
isaac-sim:fpgs-devfrom
ooctipus:ooctipus/fpgs-non-wip-pin-20260718

Conversation

@ooctipus

Copy link
Copy Markdown
Collaborator

Description

Updates the root Newton pin from 186502cec5db4b80a4cc235c9a6f5e4266ee2c07 to the public aae676fee7b08c945aa2746f673fb924f2e12c22 integration. The new commit brings Dylan Turpin’s June 19 non-WIP FPGS line onto the current Newton base while retaining the newer Newton APIs required by IsaacLab.

The dependency remains pinned to the public ooctipus/newton commit; this does not add a local path override. The imported matrix-free warm-start remains disabled by default and is not enabled by IsaacLab presets.

Type of change

  • Bug fix (non-breaking dependency update)

Validation

  • Newton pre-commit: all hooks passed
  • Newton serial FeatherPGS suite: 25 passed
  • IsaacLab test_uv_run_pyproject.py: 6 passed
  • All applicable pre-commit hooks for pyproject.toml: passed
  • Full IsaacLab all-files pre-commit was also run; code and style hooks passed, while the existing fpgs-dev golden-image Git LFS pointer gate reported unrelated baseline files

Checklist

  • I have read and understood the contribution guidelines
  • I have run the relevant pre-commit checks
  • My changes generate no new warnings
  • Existing focused tests cover this dependency-pin change
  • No package changelog fragment is needed for this root dependency-pin-only change
  • My name already exists in CONTRIBUTORS.md

Point the FPGS development branch at the June 19 non-WIP integration on the current Newton base. Keep the project metadata pinned to the public commit rather than a local checkout.
@greptile-apps

greptile-apps Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates the pinned Newton commit in pyproject.toml from 186502c to aae676f, bringing in Dylan Turpin's June 19 non-WIP FPGS implementation on top of the existing Newton base. Both the [tool.isaaclab.versions] version string and the [tool.uv] override-dependencies git URL are updated consistently to the same hash.

  • The two Newton pin sites (newton = "..." and the newton[sim] @ git+...@... override) are kept in sync — no drift introduced.
  • The warp pin (1.15.0.dev20260626) is intentionally left unchanged; the comment noting they're "upgraded together" refers to prior bumps and does not block this Newton-only update given the passing test suite reported in the PR.
  • The source repository (ooctipus/newton.git) remains unchanged; no local path override is introduced.

Confidence Score: 5/5

Safe to merge — the change is a two-line commit-hash swap, both occurrences are kept consistent, and the PR reports a passing serial FPGS test suite plus IsaacLab uv-run tests.

The change touches only one file and replaces the same 40-character git SHA in two coordinated locations. Both the version-table entry and the uv override URL are updated identically, so there is no risk of the resolver picking different Newton builds depending on which entry wins. No logic, API surface, or configuration beyond the pin itself is affected.

No files require special attention. The only change is the Newton commit hash in pyproject.toml.

Important Files Changed

Filename Overview
pyproject.toml Updates the Newton commit pin from 186502c to aae676f in both [tool.isaaclab.versions] and [tool.uv] override-dependencies, keeping both occurrences consistent with each other.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant PY as pyproject.toml
    participant UV as uv resolver
    participant GH as github.com/ooctipus/newton.git
    participant WL as warp-lang (1.15.0.dev20260626)

    PY->>UV: "override-dependencies: newton[sim]@aae676f"
    UV->>GH: fetch commit aae676fee7b08c945aa2746f673fb924f2e12c22
    GH-->>UV: Newton + FPGS (Dylan Turpin June 19 non-WIP)
    UV->>WL: "resolve warp==1.15.0.dev20260626 (unchanged)"
    UV-->>PY: resolution complete
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant PY as pyproject.toml
    participant UV as uv resolver
    participant GH as github.com/ooctipus/newton.git
    participant WL as warp-lang (1.15.0.dev20260626)

    PY->>UV: "override-dependencies: newton[sim]@aae676f"
    UV->>GH: fetch commit aae676fee7b08c945aa2746f673fb924f2e12c22
    GH-->>UV: Newton + FPGS (Dylan Turpin June 19 non-WIP)
    UV->>WL: "resolve warp==1.15.0.dev20260626 (unchanged)"
    UV-->>PY: resolution complete
Loading

Reviews (1): Last reviewed commit: "Update Newton FPGS non-WIP pin" | Re-trigger Greptile

@ooctipus
ooctipus merged commit dc2b1b4 into isaac-sim:fpgs-dev Jul 18, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant