Make the Warp frontend mask-first#6607
Draft
hujc7 wants to merge 4 commits into
Draft
Conversation
Keep reset selection and registered manager hot paths on Warp-owned buffers, with explicit host boundaries only for legacy consumers. Default stateful frontend stages to eager execution so record/replay and capture can be layered on after correctness is established.
Preserve each task's configured actuator path instead of forcing the native Newton adapter in every Warp environment. The native path currently makes representative Go2 physics substeps roughly ten times slower, so it remains available for targeted validation without regressing the default frontend.
Keep reset masks canonical while using one explicit host predicate to avoid dispatching every reset manager for an empty selection. This recovers the eager hot path until recorded reset launches can remove the boundary.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The frontend still crossed between Warp masks, Torch index tensors, and stable-manager fallbacks in high-traffic paths. Those crossings complicated partial resets, introduced host synchronization and shared-state risks, and made graph correctness depend on mixed backend behavior.
This PR establishes the clean Warp-first baseline first: pointer-stable buffers, mask-owned reset state, Warp-native registered terms, and explicit compatibility boundaries.
Key design choices
The cleanup also fixes partial-reset correctness issues found during the work, including event-state leakage, center-of-mass sampling, termination metrics, dynamic reward weights, external-wrench selection, and identity quaternion initialization.
Performance
All measurements used one NVIDIA L40, seed 42, a serial process, Newton MJWarp physics graphs enabled, and the frontend explicitly in Warp eager mode.
Isolated develop comparison
developScaling chart
Cartpole is the upper line and Go2 is the lower line.
xychart-beta title "Warp-eager L40 throughput scaling" x-axis "Environments" [256, 1024, 4096] y-axis "Frames per second" 0 --> 1300000 line [79521, 315642, 1248380] line [58942, 229836, 741682]Cartpole remains launch/CPU-bound across this range. Go2 shows the expected diminishing frontend headroom as GPU utilization rises from 59% to 77%.
Validation
158 passedin the combined Warp/reset/manager/parity suite.3 passedin PhysX mask-forwarding coverage.9 passedin the reset-orchestration file).Training time: 1.12 seconds)../isaaclab.sh -f, changelog-fragment validation, and./isaaclab.sh -dpassed.Follow-ups and limitations
MANAGER_CALL_CONFIG='{"default": 2}'; direct capture remains opt-in withISAACLAB_WARP_DIRECT_CAPTURE=1.Type of change
Checklist
./isaaclab.sh -f../isaaclab.sh -d.CONTRIBUTORS.md.