Fix root fixing on stages without omni.physx#6613
Closed
ooctipus wants to merge 1 commit into
Closed
Conversation
Author the world fixed joint with plain-USD API through a shared create_world_fixed_joint helper so fix_root_link works on kit-less stages (usd-core only). PhysicsManager delegates to the helper instead of carrying its own authoring copy.
Collaborator
Author
|
Closing — this is already covered by #6536. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix root fixing on stages without omni.physx
What
create_world_fixed_joint(articulation_prim, stage)tosource/isaaclab/isaaclab/sim/schemas/schemas.py: a pure-USD helper that authors theworld-attached
UsdPhysics.FixedJointused to fix an articulation root link. It mirrorsthe behavior of
omni.physx.scripts.utils.createJoint(joint_type="Fixed", from_prim=None, to_prim=...): unique joint naming, walking up to the first writable ancestor forinstanceable/prototype/instance-proxy roots, anchoring
localPos0/localRot0at the rootlink's world pose, and setting break force/torque to the same effectively-unbreakable
MAX_FLOATvalue.modify_articulation_root_properties(thefix_root_linkspawn path) now calls thishelper instead of importing
omni.physx.scripts.utils.PhysicsManager.fix_articulation_rootdelegates to the same helper instead of carryingits own inline joint-authoring copy, so there is a single authoring path for every
backend.
source/isaaclab/test/sim/test_schemas_kitless_fixed_joint.py, which runs on anin-memory USD stage without launching Isaac Sim / Kit.
source/isaaclab/changelog.d/schemas-kitless-fixed-joint.rst.Why
Spawning a fixed-base articulation (
fix_root_link=True) previously importedomni.physx.scripts.utilsinsidemodify_articulation_root_properties. On stages whereomni.physxis not available (kitless / usd-core-only setups, e.g. Newton backends), thatimport raises
ModuleNotFoundError, breaking the spawn path. Authoring the joint directlywith plain USD removes the
omni.physxdependency while preserving the authored result.Sharing the helper with
PhysicsManager.fix_articulation_rootalso removes a duplicatedcopy of the joint-authoring logic.
This is a standalone correctness fix plus a regression test; no performance claims.
Evidence (existing upstream workflow)
Measured with the repository's own benchmark, identical command on the PR branch and its base (
upstream/develop@ 5c42d39):Platform: RTX 5090, Newton backend, CUDA graphs on.
Runtime evidence is not applicable; the change fixes
fix_root_linkon kit-less stages. Correctness evidence: the new regression test (test_schemas_kitless_fixed_joint.py, 2 passed) exercises the plain-USD path end-to-end.🤖 Generated with Claude Code