Draft: Per tile render history reset#6622
Draft
rilei-nvidia wants to merge 2 commits into
Draft
Conversation
rilei-nvidia
force-pushed
the
per-tile-render-history-reset
branch
from
July 20, 2026 04:27
1479a57 to
84e7ff4
Compare
huidongc
reviewed
Jul 20, 2026
Comment on lines
+722
to
+731
| self._renderer.write_array_attribute( | ||
| prim_paths=[rp], | ||
| attribute_name="omni:rtx:viewTile:renderHistoryReset:tileIndices", | ||
| tensors=[tile_indices], | ||
| ) | ||
| self._renderer.write_attribute( | ||
| prim_paths=[rp], | ||
| attribute_name="omni:rtx:viewTile:renderHistoryReset:requestId", | ||
| tensor=np.array([self._render_history_reset_request_id], dtype=np.int32), | ||
| ) |
Collaborator
There was a problem hiding this comment.
Wondering if it makes sensor to create atrribute bindings? Env reset is not a rare op during training.
pbarejko
reviewed
Jul 20, 2026
| """ | ||
| pass | ||
|
|
||
| def reset_tile_history(self, render_data: Any, env_ids: Sequence[int] | None) -> None: |
Collaborator
There was a problem hiding this comment.
I would just call it reset. reset_tile_history seems very specific. If it's called more generic as reset it could be reused for other reasons.
pbarejko
reviewed
Jul 20, 2026
| return | ||
|
|
||
| if env_ids is None: | ||
| tile_indices = np.arange(render_data.num_envs, dtype=np.float32) |
Collaborator
There was a problem hiding this comment.
nit:
`/rtx/viewTile/renderHistoryReset/tileIndices`
* `float[]`
* `-1.0` resets all valid tiles
* `-2.0 `is no-op/default padding
* `0..N-1` reset selected flat tile indices
then this becomes:
if env_ids is None:
tile_indices = np.array([-1.0], dtype=np.float32)
pbarejko
reviewed
Jul 20, 2026
| # reset indices. The copy is negligible: this runs once per reset, | ||
| # not per frame, on an array of at most num_envs floats. | ||
| ids = env_ids.cpu() if isinstance(env_ids, torch.Tensor) else env_ids | ||
| tile_indices = np.asarray(ids, dtype=np.float32) |
Collaborator
There was a problem hiding this comment.
This could be fragile because you made an assumption:
rel camera = [
</World/envs/env_0/Camera>, # tile 0
</World/envs/env_1/Camera>, # tile 1
</World/envs/env_2/Camera>, # tile 2
]
could the mapping of the indices be different? i.e.
rel camera = [
</World/envs/env_0/Camera>, # tile 0
</World/envs/env_2/Camera>, # tile 2
</World/envs/env_1/Camera>, # tile 1
]
pbarejko
reviewed
Jul 20, 2026
| self._render_history_reset_request_id += 1 | ||
| rp = self._render_product_paths[0] | ||
|
|
||
| self._renderer.write_array_attribute( |
Collaborator
There was a problem hiding this comment.
Since you experience problem with the feature, do we know if this write op succeeded? Can you read it back for debugging?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
./isaaclab.sh -p -m pytest -s -rA -k "ovphysx" source/isaaclab_tasks/test/core/test_rendering_history_reset_cartpole_kitless.pyStill get a faint streak post tile history reset:
Type of change
Screenshots
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there