fixbug: incorrect message displayed when an order is saved on dev #3643
Conversation
WalkthroughNew translation strings for the "saved-order" message were introduced across English and Ukrainian localization files in both general and "ubs-user" contexts. The message informs users that their order has been saved and can be accessed in their personal account, with the English version including an order ID placeholder. No existing translation keys or values were modified or removed; only additions were made to the relevant JSON files. Changes
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/assets/i18n/en.json(1 hunks)src/assets/i18n/ua.json(1 hunks)src/assets/i18n/ubs-user/en.json(1 hunks)src/assets/i18n/ubs-user/ua.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build (18.x)
🔇 Additional comments (2)
src/assets/i18n/en.json (1)
551-552: Add newsaved-ordersnack-bar message
The English translation keysnack-bar.saved-orderwith the{{orderId}}placeholder has been correctly added. This aligns with the PR objective of informing users where to find their saved order.src/assets/i18n/ubs-user/en.json (1)
35-36: Add newsaved-ordermessage in UBS-user English file
The UBS-user English translation keysnack-bar.saved-orderwith the{{orderId}}placeholder is correctly added and matches the general localization.
| }, | ||
| "saved-order": "Замовлення успішно збережене" |
There was a problem hiding this comment.
Missing {{orderId}} placeholder in Ukrainian UBS-user translation
The new Ukrainian snack-bar.saved-order string does not include the №{{orderId}} placeholder used in the English version. If the frontend interpolates the order ID, you’ll either see no ID or a broken value. Please confirm if omitting the placeholder is intentional; otherwise update to something like:
"saved-order": "Замовлення №{{orderId}} успішно збережене"| }, | ||
| "saved-order": "Замовлення успішно збережене" |
There was a problem hiding this comment.
Missing {{orderId}} placeholder in main Ukrainian translation
Similarly, the main Ukrainian file’s snack-bar.saved-order key lacks the №{{orderId}} placeholder. For consistency and correct interpolation, please update it to:
"saved-order": "Замовлення №{{orderId}} успішно збережене"
|
There was a bug in production where, when an order was saved without payment, an incorrect message was displayed.
Fix: Updated the logic for handling orders that are saved without payment on dev.
Summary by CodeRabbit