Skip to content

fixbug: incorrect message displayed when an order is saved on dev #3643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fixbug: incorrect message displayed when an order is saved on dev #3643

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/assets/i18n/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,8 @@
"friend-added-success": "Friend invitation accepted",
"friend-declined-success": "Friend invitation declined",
"habit-invite-success": "Invite request sent"
}
},
"saved-order": "Now you can find your order №{{orderId}} in your personal account and continue processing it at any time"
},
"user": {
"add-comment": {
Expand Down
3 changes: 2 additions & 1 deletion src/assets/i18n/ua.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,8 @@
"friend-added-success": "Запит на дружбу прийнято",
"friend-declined-success": "Запит на дружбу відхилено",
"habit-invite-success": "Запит на запрошення надіслано"
}
},
"saved-order": "Замовлення успішно збережене"
Comment on lines +560 to +561
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Missing {{orderId}} placeholder in main Ukrainian translation
Similarly, the main Ukrainian file’s snack-bar.saved-order key lacks the №{{orderId}} placeholder. For consistency and correct interpolation, please update it to:

"saved-order": "Замовлення №{{orderId}} успішно збережене"

},
"user": {
"add-comment": {
Expand Down
3 changes: 2 additions & 1 deletion src/assets/i18n/ubs-user/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"snack-bar": {
"error": {
"exist-address": "This address has already been added"
}
},
"saved-order": "Now you can find your order №{{orderId}} in your personal account and continue processing it at any time"
}
}
3 changes: 2 additions & 1 deletion src/assets/i18n/ubs-user/ua.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"snack-bar": {
"error": {
"exist-address": "Ця адреса вже додана"
}
},
"saved-order": "Замовлення успішно збережене"
Comment on lines +35 to +36
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Missing {{orderId}} placeholder in Ukrainian UBS-user translation
The new Ukrainian snack-bar.saved-order string does not include the №{{orderId}} placeholder used in the English version. If the frontend interpolates the order ID, you’ll either see no ID or a broken value. Please confirm if omitting the placeholder is intentional; otherwise update to something like:

"saved-order": "Замовлення №{{orderId}} успішно збережене"

}
}
Loading