-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: add option to change username #5199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Note: This conflicts with #2469 due to the use of materialized views. |
Users that changed their username to something like `User`, were unable to login because the username is downcased on routes/login.cr
"accounts_username_required_field": "Username is a required field", | ||
"accounts_username_empty": "Username cannot be empty", | ||
"accounts_username_is_the_same": "This is your username, use another one", | ||
"accounts_username_taken": "Username is already taken, use another one" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd need to use UUIDs of some sort to differenciate accounts at some point. I'm worried that account name switching could be used to find if someone else is registered on this instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried that account name switching could be used to find if someone else is registered on this instance.
That is already possible in the login page, if you insert a registered user with a wrong password it will return Wrong username or password
.
Unless you are referring to another case I'm missing
Co-authored-by: syeopite <[email protected]>
Tested and it works fine. I made this for people that want to change their username on public Invidious instances without having to create a new account or having to contact the instance maintainer to change their username. It also updates the materialized views sha256 ids, so if a user changed their account name from
user
touser2
and a new user registers on the instance with the usernameuser
, there shouldn't be a relation collision (when the collision happens, this is displayed:relation "subscriptions_sha256" already exists
)Tested:
user1
touser2
, subscriptions are maintained across username changesuser2
back touser1
works well.user1
anduser1
)