-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: add option to change username #5199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Fijxu
wants to merge
6
commits into
iv-org:master
Choose a base branch
from
Fijxu:change-username
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
e27dd02
feat: add option to change username
Fijxu eff1a10
fix: rename subscriptions materialized view of the user too
Fijxu 0c83eb2
fix: downcase username and limit username lenght (from routes/login.cr)
Fijxu a1a66e0
change arg name and prefix locales
Fijxu deb342b
fix wrong translation
Fijxu 31b48ec
Update src/invidious/routes/account.cr
Fijxu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
<% content_for "header" do %> | ||
<title><%= translate(locale, "accounts_change_username") %> - Invidious</title> | ||
<% end %> | ||
|
||
<div class="pure-g"> | ||
<div class="pure-u-1 pure-u-lg-1-5"></div> | ||
<div class="pure-u-1 pure-u-lg-3-5"> | ||
<div class="h-box"> | ||
<form class="pure-form pure-form-aligned" action="/change_username?referer=<%= URI.encode_www_form(referer) %>" method="post"> | ||
<legend><%= translate(locale, "") %></legend> | ||
|
||
<fieldset> | ||
<label for="accounts_new_username"><%= translate(locale, "accounts_new_username") %> :</label> | ||
<input required class="pure-input-1" name="new_username" type="text" placeholder="<%= translate(locale, "new_username") %>"> | ||
|
||
<button type="submit" name="action" value="change_username" class="pure-button pure-button-primary"> | ||
<%= translate(locale, "accounts_change_username") %> | ||
</button> | ||
|
||
<input type="hidden" name="csrf_token" value="<%= HTML.escape(csrf_token) %>"> | ||
</fieldset> | ||
</form> | ||
</div> | ||
</div> | ||
<div class="pure-u-1 pure-u-lg-1-5"></div> | ||
</div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd need to use UUIDs of some sort to differenciate accounts at some point. I'm worried that account name switching could be used to find if someone else is registered on this instance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is already possible in the login page, if you insert a registered user with a wrong password it will return
Wrong username or password
.Unless you are referring to another case I'm missing