feat: route to invidious companion on downloads#5224
Merged
unixfox merged 1 commit intoiv-org:masterfrom May 2, 2025
Merged
Conversation
SamantazFox
reviewed
May 18, 2025
| str << "<form" | ||
| str << " class=\"pure-form pure-form-stacked\"" | ||
| str << " action='/download'" | ||
| str << " action='#{url}'" |
Member
There was a problem hiding this comment.
This needs to be URL encoded!
Suggested change
| str << " action='#{url}'" | |
| str << " action='" << URI.encode_www_form(url) << "'" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets the download URL to invidious companion (as enabled in iv-org/invidious-companion#41) when companion is used.
There is a secondary way of approaching this - proxying the download through invidious. However, it looks like the
CompanionConnectionPoolis set up to only have a short timeout, and a download endpoint will need to allow for long requests.Note that this approach embeds the companion URL in the page, which means the
checkparam would eventually expire. It looks like that's 6 hours though, so I'm not sure that's too much of a concern.There's also a couple of extra bits needed in companion to make this work well, all in iv-org/invidious-companion#95
That PR does 2 things:
checkquery param is passed on to thelatestVersioncall that's made so that it doesn't error out.Without that PR merged, this still works, but only if
verify_requestisfalsein invidious-companion.Addresses #5218