Markus' PEN review.#86
Conversation
This is in particular fixing some registry aspects (e.g., we don't want mixed-case identifiers, and it's important to have a sample record). You're sure calling this thing obscore_radio is so preferable over the obs_radio that's already present in some services? It's also more chars to type... I am 100% sure that registering an obs_radio table musst entail the presence of ivoa.obscore. Anything else would be frivolous and useless. Let's not specify for that, and let's use a sane discovery query. I'm also fixing a few language things in the first part but then ran out of time while reviewing.
Updated AUTHOR_EMAIL to include additional contact.
Removed a todo comment regarding the citation of an IVOA note and added a note about the document being uploaded.
Removed a comment about explaining the importance of certain parameters for predicting minimal baseline.
loumir
left a comment
loumir
left a comment
There was a problem hiding this comment.
thanks for the various updates .
I have added a few typos corrections and complement as responses to the \todo.
Clarified the access method for visibility data maps and corrected the language regarding their representation in ObsDataset.
loumir
left a comment
loumir
left a comment
There was a problem hiding this comment.
changed text for uv maps access
Corrected a comment regarding the exposure of maps via DataLink service.
Bonnarel
left a comment
Bonnarel
left a comment
There was a problem hiding this comment.
I approve this Pull request according it takes into account Mireille's comments
This is extension to obscore, should be clear in the name
OK
Thanks
|
3 participants
This is in particular fixing some registry aspects (e.g., we don't want mixed-case identifiers, and it's important to have a sample record).
You're sure calling this thing obscore_radio is so preferable over the obs_radio that's already present in some services? It's also more chars to type...
I am 100% sure that registering an obs_radio table musst entail the presence of ivoa.obscore. Anything else would be frivolous and useless. Let's not specify for that, and let's use a sane discovery query.
I'm also fixing a few language things in the first part but then ran out of time while reviewing.
I have also added a couple of todos where I couldn't really work out what is being said.