Skip to content

Conversation

@roivanov
Copy link

@roivanov roivanov commented Oct 4, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

goatwu1993 and others added 28 commits September 11, 2024 09:34
googleapis#2331)

* docs: update manifest-releaser docs to add some clarification around the package path

- make it a little clearer that the package path should be a folder and not a file
- give an example for creating an empty release-please-manifest.json

Signed-off-by: Amo Chumber <[email protected]>

* Update manifest-releaser.md

---------

Signed-off-by: Amo Chumber <[email protected]>
Co-authored-by: Jeff Ching <[email protected]>
…googleapis#2323)

* docs: add compile step to local run command

* fix: prevent open release PRs from being mistaken as current releases

---------

Co-authored-by: Jeff Ching <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…erged with `autorelease:closed` (googleapis#2255)

* doc: Update troubleshooting.md

* Update troubleshooting.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…acter from `${component}` title pattern) (googleapis#2330)

* fix: Remove space from pull-request-title.ts

* test: Fix failing tests

* feat: Introduce new parameter `componentNoSpace`; Partially revert previous changes

* feat: Update docs

* chore: Remove unnecessary `console.log()`

* style: Run `npm fix` across the project

* chore: Update snapshots

* feat: Add `componentNoSpace` parameter to merge plugin

* style: Adjust code style; Run `npm fix`

* fix: Docs parameter name
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* feat: handle multiple commits in a single message

- updated `splitMessages` function to handle multiple conventional commits within the main message
- added logic to separate conventional commits (feat, fix, docs, etc.) within the main message
- preserved the original message structure outside of nested commit blocks
- enhanced breaking change detection from commit body in `toConventionalChangelogFormat` and `postProcessCommits` functions

Resolves googleapis#2357

* test: new test case for parsing multiple commits

- added new test cases for parsing multiple commits from a single message
- added fixture file for multiple commits in a single message
- changed the order of the expected commits in `multiple-messages` and `1257-breaking-change` fixtures since the order of the commits in the is not reversed anymore

* test: remove duplicate test for parsing multiple commits
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…ewlines (googleapis#2390)

* fix: when parsing multiple messages from a single commit, require 2 newlines

* test: fix test name

* try optional windows newlines
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…pis#2310)

* fix merging behaviour in plugin

* add test

* remove unused test snapshot

* update licnese header

* considering plugin schema carefully

* add unit test

* remove `determineMerge` and set default value directly

* set default value for `separatePullRequests` in `buildPlugin`

---------

Co-authored-by: Jeff Ching <[email protected]>
…eapis#2398)

* fix: match full artifact id when updating versions

* add unit tests

* lint

* fix unit test

* lint

* restore package

* restore package

* add unit test
renovate-bot and others added 30 commits November 12, 2024 19:28
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* feat: add "always-update" config option

Fixes googleapis#1459

This patch adds a new option "always-update" that forces existing pull
requests to be updated even when there are no changes to the
release notes. This is useful, for example, when the repository
enforces pull requests to be up-to-date with the main branch before
they can be merged. Without this option set to `true`, that is, with the
default behavior of release-please, if the last commit made to the
main branch does not appear in the release notes, the existing pull
request branch would not be rebased.

* feat: apply suggested changes

---------

Co-authored-by: Fabian Meyer <[email protected]>
Co-authored-by: Jeff Ching <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* feat: add strategy for R packages. Closes googleapis#2151

* chore: format and fix linting errors

* chore: remove unused package name getter

* chore: upload snapshot

* chore: remove unused module

* chore: add license header

* test: fix snapshot, license years

---------

Co-authored-by: Jeff Ching <[email protected]>
Bumps [jsonpath-plus](https://github.com/s3u/JSONPath) from 10.0.7 to 10.2.0.
- [Release notes](https://github.com/s3u/JSONPath/releases)
- [Changelog](https://github.com/JSONPath-Plus/JSONPath/blob/main/CHANGES.md)
- [Commits](JSONPath-Plus/JSONPath@v10.0.7...v10.2.0)

---
updated-dependencies:
- dependency-name: jsonpath-plus
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(deps): bump dependency versions

* deps: update jsonpath-plus to 10.3.0
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* feat: allow date updating in generic strategy

Allow updating of dates using the generic updater, by adding a
x-release-please-date or x-release-please-version-date (to update both
version and date) to a file anywhere.

The implementation is still very basic. The date is retrieved by just
checking the current date, but a better approach would be to look at the
timestamp of the previous feat/fix or breaking change for a conventional
commit, I think.

I've added an option --date-format to specify the date format. There are
no assertions with respect to this right now, and the regex matching can
be improved in several ways.

One option I considered was to try to auto-detect the date format, but I
think this is bound to be problematic because there are ambiguities in
date formatting.

Fixes googleapis#1798

* fixup! feat: allow date updating in generic strategy

* fixup! feat: allow date updating in generic strategy

* test: fix snapshot

---------

Co-authored-by: Jeff Ching <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…2488)

* Python PEP621: Suggest pyproject.toml instead of setup.py

Modern Python projects favor configuring with `pyproject.toml` over the `setup.py`.

https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html
> Starting with [PEP 621](https://peps.python.org/pep-0621), the Python community selected `pyproject.toml` as a standard way of specifying project metadata. `Setuptools` has adopted this standard and will use the information contained in this file as an input in the build process.

* fix markdown link

---------

Co-authored-by: Jeff Ching <[email protected]>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
feat(deps)!: update octokit to v20
Bumps [node-fetch](https://github.com/node-fetch/node-fetch) from 2.6.0 to 2.6.7.
- [Release notes](https://github.com/node-fetch/node-fetch/releases)
- [Commits](node-fetch/node-fetch@v2.6.0...v2.6.7)

---
updated-dependencies:
- dependency-name: node-fetch
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* test(deps): update mocha to v10

* chore: fix lint
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* feat: Add skip changelog flag

* WIP

* add tests

* revert changes to package.json
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Bumps  and [brace-expansion](https://github.com/juliangruber/brace-expansion). These dependencies needed to be updated together.

Updates `brace-expansion` from 2.0.1 to 2.0.2
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](juliangruber/brace-expansion@v2.0.1...v2.0.2)

Updates `brace-expansion` from 1.1.11 to 2.0.2
- [Release notes](https://github.com/juliangruber/brace-expansion/releases)
- [Commits](juliangruber/brace-expansion@v2.0.1...v2.0.2)

---
updated-dependencies:
- dependency-name: brace-expansion
  dependency-version: 2.0.2
  dependency-type: indirect
- dependency-name: brace-expansion
  dependency-version: 2.0.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.