Reproduce linting checks from the main repo #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: danish9039 <[email protected]>
yurishkuro
reviewed
Jan 20, 2025
Signed-off-by: hippie-danish <[email protected]>
Signed-off-by: danish9039 <[email protected]>
yurishkuro
reviewed
Jan 22, 2025
yurishkuro
reviewed
Jan 22, 2025
yurishkuro
reviewed
Jan 22, 2025
yurishkuro
reviewed
Jan 22, 2025
Signed-off-by: danish9039 <[email protected]>
|
|
|
why are we not getting these errors in jaeger repo? |
because main jaeger repo uses |
|
the objective was to use the same settings as the main repo |
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: hippie-danish <[email protected]>
yurishkuro
reviewed
Jan 25, 2025
yurishkuro
reviewed
Jan 25, 2025
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: hippie-danish <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
=======================================
Coverage 87.85% 87.85%
=======================================
Files 12 12
Lines 568 568
=======================================
Hits 499 499
Misses 67 67
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
yurishkuro
reviewed
Jan 28, 2025
yurishkuro
reviewed
Jan 28, 2025
yurishkuro
reviewed
Jan 28, 2025
yurishkuro
reviewed
Jan 28, 2025
yurishkuro
reviewed
Jan 28, 2025
yurishkuro
reviewed
Jan 28, 2025
yurishkuro
reviewed
Jan 28, 2025
yurishkuro
reviewed
Jan 28, 2025
Signed-off-by: danish9039 <[email protected]>
Signed-off-by: danish9039 <[email protected]>
yurishkuro
reviewed
Jan 31, 2025
yurishkuro
approved these changes
Jan 31, 2025
|
Thanks! |
4 tasks
yurishkuro
pushed a commit
that referenced
this pull request
Jan 31, 2025
## Which problem is this PR solving? - part of jaegertracing/jaeger#6570 ## Description of the changes - extracted` https://raw.githubusercontent.com/jaegertracing/jaeger/main/scripts` into a variable `$(SCRIPTS_URL)` #121 (comment) ## How was this change tested? - ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: danish9039 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test