Hide minimap when timeline is hidden#3764
Conversation
When the trace timeline is hidden via Settings, the minimap (which is another representation of the timeline) should also be hidden. This adds timelineBarsVisible to the hideMap condition so the minimap is hidden whenever the timeline bars are not visible. Closes jaegertracing#3762 Signed-off-by: okxint <cashmein.eth@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR aligns the TracePage minimap visibility with the timeline visibility setting, ensuring the minimap is hidden when timeline bars are turned off (closing #3762).
Changes:
- Update
TracePage’shideMapcondition to also hide the minimap whentimelineBarsVisibleisfalse. - Add a unit test to verify the minimap is not rendered when timeline bars are hidden.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/jaeger-ui/src/components/TracePage/index.tsx | Extends hideMap logic to include !timelineBarsVisible, hiding the minimap when the timeline is hidden. |
| packages/jaeger-ui/src/components/TracePage/index.test.jsx | Adds a regression test ensuring the minimap is not rendered when timeline bars are disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Parship12
left a comment
There was a problem hiding this comment.
add screenshots or a short recording to show the before/after ui behavior for this change?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3764 +/- ##
=======================================
Coverage 90.29% 90.29%
=======================================
Files 329 329
Lines 10090 10092 +2
Branches 2623 2623
=======================================
+ Hits 9111 9113 +2
Misses 853 853
Partials 126 126 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…tion Signed-off-by: okxint <cashmein.eth@gmail.com>
|
Addressed the review feedback - moved the |
Signed-off-by: Yuri Shkuro <github@ysh.us>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| it('is true when timeline bars are hidden', () => { | ||
| mockLayoutPrefsStore.timelineBarsVisible = false; | ||
| renderWithRouter(<TracePage {...defaultProps} />); | ||
|
|
There was a problem hiding this comment.
Test name is ambiguous: within calculates hideMap correctly, the new it('is true when timeline bars are hidden'...) doesn’t mention hideMap/minimap, and it only asserts on DOM presence. Consider renaming to explicitly reference hideMap/minimap and (optionally) asserting capturedHeaderProps.hideMap === true to make the intent clearer and less coupled to the mock header markup.
| it('is true when timeline bars are hidden', () => { | |
| mockLayoutPrefsStore.timelineBarsVisible = false; | |
| renderWithRouter(<TracePage {...defaultProps} />); | |
| it('sets hideMap to true and hides the minimap when timeline bars are hidden', () => { | |
| mockLayoutPrefsStore.timelineBarsVisible = false; | |
| renderWithRouter(<TracePage {...defaultProps} />); | |
| expect(capturedHeaderProps.hideMap).toBe(true); |
|
This has approvals from @Parship12 and @yurishkuro, and the review feedback has been addressed. Ready to merge whenever convenient. Thanks! |


Which problem is this PR solving?
Closes #3762
When the trace timeline is hidden via Settings, the minimap (which is just another representation of the timeline) remains visible. It should be hidden too.
Description of the changes
Added
!timelineBarsVisibleto thehideMapcondition inTracePage, so the minimap is hidden whenever the timeline bars are not visible.How was this change tested?
Added a unit test that verifies the minimap is hidden when
timelineBarsVisibleisfalse.