Skip to content

Hide minimap when timeline is hidden #3764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
okxint wants to merge 4 commits into
base: main
Choose a base branch
from
+17 −1
Open

Hide minimap when timeline is hidden #3764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d222b7
fix(TracePage): Hide minimap when timeline is hidden
okxint Apr 20, 2026
89b8502
fix(test): Move timelineBarsVisible reset to afterEach for test isola…
okxint Apr 22, 2026
b3c5c86
Undo package-lock.json changes
yurishkuro Apr 23, 2026
e42dd3a
Merge branch 'main' into fix/hide-minimap-with-timeline
yurishkuro Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/jaeger-ui/src/components/TracePage/index.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,6 +608,20 @@ describe('<TracePage>', () => {
const spanGraph = screen.queryByTestId('span-graph');
expect(spanGraph).not.toBeInTheDocument();
});

describe('when timeline bars are hidden', () => {
afterEach(() => {
mockLayoutPrefsStore.timelineBarsVisible = true;
});

it('is true when timeline bars are hidden', () => {
mockLayoutPrefsStore.timelineBarsVisible = false;
renderWithRouter(<TracePage {...defaultProps} />);

Comment on lines +617 to +620
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test name is ambiguous: within calculates hideMap correctly, the new it('is true when timeline bars are hidden'...) doesn’t mention hideMap/minimap, and it only asserts on DOM presence. Consider renaming to explicitly reference hideMap/minimap and (optionally) asserting capturedHeaderProps.hideMap === true to make the intent clearer and less coupled to the mock header markup.

Suggested change
it('is true when timeline bars are hidden', () => {
mockLayoutPrefsStore.timelineBarsVisible = false;
renderWithRouter(<TracePage {...defaultProps} />);
it('sets hideMap to true and hides the minimap when timeline bars are hidden', () => {
mockLayoutPrefsStore.timelineBarsVisible = false;
renderWithRouter(<TracePage {...defaultProps} />);
expect(capturedHeaderProps.hideMap).toBe(true);

Copilot uses AI. Check for mistakes.
const spanGraph = screen.queryByTestId('span-graph');
expect(spanGraph).not.toBeInTheDocument();
});
});
});

describe('calculates hideSummary correctly', () => {
Expand Down
4 changes: 3 additions & 1 deletion packages/jaeger-ui/src/components/TracePage/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,9 @@ export function TracePageImpl(props: TProps) {
detailPanelMode,
enableSidePanel,
hideMap: Boolean(
viewType !== ETraceViewType.TraceTimelineViewer || (embedded && embedded.timeline.hideMinimap)
viewType !== ETraceViewType.TraceTimelineViewer ||
(embedded && embedded.timeline.hideMinimap) ||
!timelineBarsVisible
),
hideSummary: Boolean(embedded && embedded.timeline.hideSummary),
linkToStandalone: getUrl(id),
Expand Down
Loading