Adding capability to deploy using Docker.#1525
Open
Harshraj9812 wants to merge 4 commits intojagrosh:masterfrom
Open
Adding capability to deploy using Docker.#1525Harshraj9812 wants to merge 4 commits intojagrosh:masterfrom
Harshraj9812 wants to merge 4 commits intojagrosh:masterfrom
Conversation
jogerj
suggested changes
Apr 1, 2024
Comment on lines
+15
to
+16
| RUN curl -LJO "https://github.com/jagrosh/MusicBot/releases/download/$MUSICBOT_VERSION/JMusicBot-$MUSICBOT_VERSION.jar" \ | ||
| && mv "JMusicBot-$MUSICBOT_VERSION.jar" JMusicBot.jar |
There was a problem hiding this comment.
It would be preferred to use the build artifacts from the previous job instead of fetching the release file like this. The files attached on a release are not necessarily the same as builds from source code.
Tip: with curl the mv step is also completely unnecessary since you can also save the file as a specified filename
Suggested change
| RUN curl -LJO "https://github.com/jagrosh/MusicBot/releases/download/$MUSICBOT_VERSION/JMusicBot-$MUSICBOT_VERSION.jar" \ | |
| && mv "JMusicBot-$MUSICBOT_VERSION.jar" JMusicBot.jar | |
| RUN curl -o JMusicBot.jar -LJ "https://github.com/jagrosh/MusicBot/releases/download/$MUSICBOT_VERSION/JMusicBot-$MUSICBOT_VERSION.jar" |
Author
There was a problem hiding this comment.
Hi @jogerj
Can you please help me with the change required to get the build form Artificats, I found this way more easier and understandable.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request...
Description
These changes are to make this awesome bot docker deployment ready for Ease of Deployment.
Things added -
Config Changes needed
Purpose
These changes will add a new capability to this bot to be deployed with Docker, Which will ease the Deployment process without any dependency on OS.
Relevant Issue(s)
No fix for any ongoing issue, This is for additional deployment improvement.