-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Adding capability to deploy using Docker. #1525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| name: Build MusicBot Docker Image | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| musicbot_version: | ||
| description: 'Jagrosh/MusicBot version (required) Ex-0.3.9' | ||
| required: true | ||
| default: '0.3.9' | ||
|
|
||
| jobs: | ||
| Build-Push-Docker-Image: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| musicbot_version: ${{ github.event.inputs.musicbot_version }} | ||
|
|
||
| steps: | ||
| - name: Checkout Repository | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Building Docker Image | ||
| run: | | ||
| echo ${musicbot_version} | ||
| docker build --build-arg MUSICBOT_VERSION=${musicbot_version} -t ${{ secrets.DOCKER_USERNAME }}/jmusicbot:${musicbot_version} . | ||
|
|
||
| - name: Log in to Docker Hub | ||
| env: | ||
| DOCKER_USERNAME: ${{ secrets.DOCKER_USERNAME }} | ||
| DOCKER_PASSWORD: ${{ secrets.DOCKER_PASSWORD }} | ||
| run: | | ||
| echo $DOCKER_PASSWORD | docker login -u $DOCKER_USERNAME --password-stdin | ||
|
|
||
| - name: Pushing Docker Image to Docker Hub | ||
| run: docker push ${{ secrets.DOCKER_USERNAME }}/jmusicbot:${musicbot_version} |
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,22 @@ | ||||||||
| FROM openjdk:11-jre | ||||||||
|
|
||||||||
| ARG MUSICBOT_VERSION | ||||||||
|
|
||||||||
| WORKDIR / | ||||||||
|
|
||||||||
| RUN pwd | ||||||||
| RUN ls -lrt | ||||||||
|
|
||||||||
| ENV TOKEN harsh | ||||||||
|
|
||||||||
| RUN echo "Building MusicBot version: $MUSICBOT_VERSION" | ||||||||
|
|
||||||||
| # Download and rename the JAR file based on the provided version | ||||||||
| RUN curl -LJO "https://github.com/jagrosh/MusicBot/releases/download/$MUSICBOT_VERSION/JMusicBot-$MUSICBOT_VERSION.jar" \ | ||||||||
| && mv "JMusicBot-$MUSICBOT_VERSION.jar" JMusicBot.jar | ||||||||
|
Comment on lines
+15
to
+16
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be preferred to use the build artifacts from the previous job instead of fetching the release file like this. The files attached on a release are not necessarily the same as builds from source code. Tip: with curl the mv step is also completely unnecessary since you can also save the file as a specified filename
Suggested change
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi @jogerj Can you please help me with the change required to get the build form Artificats, I found this way more easier and understandable. |
||||||||
|
|
||||||||
| # Copying Repo config.txt file to Build | ||||||||
| COPY config.txt /config.txt | ||||||||
|
|
||||||||
| # Replace occurrences of ${BOT-TOKEN} with the value of TOKEN in config.txt during runtime | ||||||||
| CMD ["sh", "-c", "sed -i 's/${BOT-TOKEN}/${TOKEN}/g' /config.txt && java -Dnogui=true -jar /JMusicBot.jar"] | ||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| version: "3" | ||
| services: | ||
| discord-bot: | ||
| container_name: Discord-Hr-Music-bot | ||
| restart: unless-stopped | ||
| # Modify Version as per input[0.3.9] | ||
| image: [DOCKER HUB USER]/jmusic:[version] | ||
| labels: | ||
| # This is for Watchtower to Ignore Updating this Image. | ||
| - "com.centurylinklabs.watchtower.enable=false" | ||
| environment: | ||
| # Add your Bot TOken below | ||
| - TOKEN=[BOT TOKEN] |
Uh oh!
There was an error while loading. Please reload this page.