fix valid_url?/1 backtracking that accepted invalid trailing TLDs#17
Merged
Conversation
The trailing `\/?.*` in @url_regexp let `.*` swallow leftover characters as a path, so URLs like `https://example.com.ñ` and `https://example.abcdef` matched via TLD backtracking. Restrict the path part to start with `/`, `?`, or `#` so no domain-label leftovers can be absorbed.
There was a problem hiding this comment.
Pull request overview
This PR tightens Funkspector.Utils.valid_url?/1 so trailing characters after the TLD can no longer be backtracked into the old catch-all path suffix. It fits into the codebase by improving the URL gatekeeper used before loading or resolving documents.
Changes:
- Updated the URL validation regex to require any optional suffix to start with
/,?, or#. - Added regression tests for invalid URLs like
https://example.com.ñandhttps://example.abcdef.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
lib/funkspector/utils.ex |
Narrows the regex used by valid_url?/1 to block the reported trailing-TLD backtracking case. |
test/utils_test.exs |
Adds regression coverage for invalid trailing segments after otherwise valid-looking domains. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trailing
\/?.*in @url_regexp let.*swallow leftover characters as a path, so URLs likehttps://example.com.ñandhttps://example.abcdefmatched via TLD backtracking. Restrict the path part to start with/,?, or#so no domain-label leftovers can be absorbed.Fixes #14