Skip to content

fix valid_url?/1 backtracking that accepted invalid trailing TLDs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaimeiniesta merged 1 commit into from
May 4, 2026
Merged

fix valid_url?/1 backtracking that accepted invalid trailing TLDs #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/funkspector/utils.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ defmodule Funkspector.Utils do
and URL validation using a regular expression that supports internationalized domain names.
"""

@url_regexp ~r/\Ahttp(s?)\:\/\/[a-zñäëïöüáéíóúàèìòùâêîôû0-9\-_]+([\.]{1}[a-zñäëïöüáéíóúàèìòùâêîôû0-9\-]+)*\.[a-z0-9]{2,5}(([0-9]{1,5})?(:(\d{1,5}))?\/?.*)?\z/i
@url_regexp ~r/\Ahttp(s?)\:\/\/[a-zñäëïöüáéíóúàèìòùâêîôû0-9\-_]+([\.]{1}[a-zñäëïöüáéíóúàèìòùâêîôû0-9\-]+)*\.[a-z0-9]{2,5}(([0-9]{1,5})?(:(\d{1,5}))?([\/\?#].*)?)?\z/i
Comment thread
jaimeiniesta marked this conversation as resolved.

@doc """
Converts relative URLs to absolute URLs using the given base URL.
Expand Down
6 changes: 6 additions & 0 deletions test/utils_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,12 @@ defmodule UtilsTest do
refute Utils.valid_url?("https://example.ññ")
end

test "returns false when a valid TLD is followed by invalid trailing segments" do
refute Utils.valid_url?("https://example.com.ñ")
refute Utils.valid_url?("https://example.com.ññ")
refute Utils.valid_url?("https://example.abcdef")
end

test "returns false for non-HTTP URLs" do
refute Utils.valid_url?("ftp://example.com")
refute Utils.valid_url?("mailto:user@example.com")
Expand Down
Loading