Member mute on conference

[avoylenko]

It seems like mute/unmute was never working for Conference task, so fixing this.

[davehorton]

why async when you are not awaiting on a promise anywhere

[avoylenko]

It not true, we are attaching the catch block here:

jambonz-feature-server/lib/session/call-session.js

Line 1531 in 7fa0041

task.mute(callSid, mute).catch((err) => this.logger.error(err, 'CallSession:_lccMuteStatus'));

[davehorton]

I still don't agree on this actually.

in line 1531 we call task.mute expecting to receive a Promise.
however mute() currently doesnt return anything
it does call doConferenceMute() which returns nothing.

The fact that we expect a Promise in line 1531 does not mean that the called function (task.mute()) needs to be declared async -- it can return a Promise without being declared async. It only needs to be declared async if it uses await.

I prefer not to declare a function aysnc unless it uses await syntax within the function body. Let me know if you spot problems in my reasoning.

[avoylenko]

@davehorton you are 100% right, we don't need the async function here, but removing it will force us to change the mute function for dial verb. See

jambonz-feature-server/lib/tasks/dial.js

Line 336 in 8bed44c

async mute(callSid, doMute) {

[avoylenko]

Extra info, the mute function is being called here based on active task

jambonz-feature-server/lib/session/call-session.js

Line 1524 in 8bed44c

async _lccMuteStatus(mute, callSid) {

[davehorton]

I really dont see why that would force a change anywhere else.

[avoylenko]

The _lccMuteStatus function calls the mute function based on session active task and since the function inside the dial task returns a promise(we have an await function there), we have to return a promise for the conference task as well.

[avoylenko]

@davehorton do you need anything else or PR can be accepted?

[davehorton]

please rebase

[davehorton]

I still don't agree on this actually.

in line 1531 we call task.mute expecting to receive a Promise.
however mute() currently doesnt return anything
it does call doConferenceMute() which returns nothing.

The fact that we expect a Promise in line 1531 does not mean that the called function (task.mute()) needs to be declared async -- it can return a Promise without being declared async. It only needs to be declared async if it uses await.

I prefer not to declare a function aysnc unless it uses await syntax within the function body. Let me know if you spot problems in my reasoning.

[avoylenko]

@davehorton could you please merge this?