Skip to content

Member mute on conference #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Member mute on conference #1048

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bb5ea86
fix: member mute on conference
avoylenko Jan 18, 2025
258f95d
Merge branch 'main' into fix-conference-mute
avoylenko Feb 16, 2025
cf2b076
Merge branch 'main' into fix-conference-mute
avoylenko Feb 24, 2025
99fc8a7
Merge branch 'main' into fix-conference-mute
avoylenko Feb 24, 2025
dd0a276
Merge branch 'main' into fix-conference-mute
avoylenko Feb 28, 2025
bb67612
Merge branch 'main' into fix-conference-mute
avoylenko Mar 3, 2025
8632bec
Merge branch 'main' into fix-conference-mute
avoylenko Apr 10, 2025
931b171
Merge branch 'main' into fix-conference-mute
avoylenko Apr 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/tasks/conference.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ class Conference extends Task {

doConferenceMute(cs, opts) {
assert (cs.isInConference);

this.logger.info(`Conference:doConferenceMute ${mute ? 'muting' : 'unmuting'} member`);
const mute = opts.conf_mute_status === 'mute';
this.ep.api(`conference ${this.confName} ${mute ? 'mute' : 'unmute'} ${this.memberId}`)
.catch((err) => this.logger.info({err}, 'Error muting or unmuting participant'));
Expand Down Expand Up @@ -549,8 +549,8 @@ class Conference extends Task {
/**
* mute or unmute side of the call
*/
mute(callSid, doMute) {
this.doConferenceMute(this.callSession, {conf_mute_status: doMute});
async mute(callSid, doMute) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why async when you are not awaiting on a promise anywhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It not true, we are attaching the catch block here:

jambonz-feature-server/lib/session/call-session.js

Line 1531 in 7fa0041

task.mute(callSid, mute).catch((err) => this.logger.error(err, 'CallSession:_lccMuteStatus'));

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't agree on this actually.

in line 1531 we call task.mute expecting to receive a Promise.
however mute() currently doesnt return anything
it does call doConferenceMute() which returns nothing.

The fact that we expect a Promise in line 1531 does not mean that the called function (task.mute()) needs to be declared async -- it can return a Promise without being declared async. It only needs to be declared async if it uses await.

I prefer not to declare a function aysnc unless it uses await syntax within the function body. Let me know if you spot problems in my reasoning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davehorton you are 100% right, we don't need the async function here, but removing it will force us to change the mute function for dial verb. See

jambonz-feature-server/lib/tasks/dial.js

Line 336 in 8bed44c

async mute(callSid, doMute) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra info, the mute function is being called here based on active task

jambonz-feature-server/lib/session/call-session.js

Line 1524 in 8bed44c

async _lccMuteStatus(mute, callSid) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really dont see why that would force a change anywhere else.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _lccMuteStatus function calls the mute function based on session active task and since the function inside the dial task returns a promise(we have an await function there), we have to return a promise for the conference task as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davehorton do you need anything else or PR can be accepted?

this.doConferenceMute(this.callSession, {conf_mute_status: doMute ? 'mute' : 'unmute'});
}

/**
Expand Down