Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compiled-objects-have-debug-symbols on macOS #205

Merged
merged 16 commits into from
Jan 27, 2024
Merged

fix compiled-objects-have-debug-symbols on macOS #205

merged 16 commits into from
Jan 27, 2024

Conversation

jameslamb
Copy link
Owner

Running this project's unit tests on my mac today (macOS 12.2.1, intel chip), I found 2 test failures that don't show up in CI:

E       AssertionError: ==================== running pydistcheck ====================
E         
E         checking '/Users/jlamb/repos/pydistcheck/tests/data/baseballmetrics-0.1.0-py3-none-macosx_10_15_x86_64.macosx_11_6_x86_64.macosx_12_5_x86_64.whl'
E         ------------ check results -----------
E         1. [compiled-objects-have-debug-symbols] Found compiled object containing debug symbols. For details, extract the distribution contents and run 'nm --debug-syms "lib/lib_baseballmetrics.dylib"'.

It seems that the nm distributed with Xcode does not support argument --debug-syms (docs), while GNU nm (docs) and llvm-nm (docs) do.

All 3 support -a to accomplish the same thing.

This proposes using nm -a instead of nm --debug-syms.

Benefits of this change

Removes a source of false positives for the compiled-objects-have-debug-symbols check.

@jameslamb jameslamb added the fix Pull request fixes a bug. label Jan 24, 2024
@jameslamb jameslamb marked this pull request as ready for review January 26, 2024 01:43
@jameslamb jameslamb merged commit f3e87a7 into main Jan 27, 2024
21 checks passed
@jameslamb jameslamb deleted the fix/nm branch January 27, 2024 07:06
@jameslamb jameslamb mentioned this pull request Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull request fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant