chore: remove unused jan_utils::string::parse_c_string helper#8073
Closed
dev-miro26 wants to merge 2 commits into
Closed
chore: remove unused jan_utils::string::parse_c_string helper#8073dev-miro26 wants to merge 2 commits into
dev-miro26 wants to merge 2 commits into
Conversation
Review: remove unused jan_utils::string::parse_c_string helperSummary: Removes the Findings:
Recommendation: can merge |
Code ReviewSummary: This PR removes the unused Findings:
Recommendation: Can merge. This is a straightforward dead-code removal with no risk. |
3 tasks
Review: chore: remove unused jan_utils::string::parse_c_string helperSummary: Removes the Positive observations
Issues and observations
Recommendation: can merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
parse_c_stringinsrc-tauri/utils/src/string.rswaspubbut had no callers anywhere in the repo — a grep acrosssrc-tauri,web-app, andcoreonly matched its own#[cfg(test)]module. It existed solely as tests-for-tests.test_parse_c_string*cases.cargo check -p jan-utilspasses;cargo test(run fromsrc-tauri/utils/) passes 32/32 with 0 failures.Fixes Issues
Self Checklist