You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove the unused parse_uuid helper and its three test_parse_uuid* cases from src-tauri/utils/src/string.rs.
jan_utils::string::parse_uuid had no external callers. The only other parse_uuid in the repo lives at src-tauri/plugins/tauri-plugin-hardware/src/vendor/vulkan.rs as a private function — the hardware plugin does not depend on jan_utils, so it cannot use the shared version.
Verified with cargo check -p jan-utils and cargo test --lib (33 passed) inside src-tauri/utils.
Summary: Removes the parse_uuid function and its three associated tests (test_parse_uuid, test_parse_uuid_zeros, test_parse_uuid_max_values) from src-tauri/utils/src/string.rs. Total: -39 lines, 0 additions.
Findings:
Correctness: Verified -- the only other parse_uuid in the repo is a private function in src-tauri/plugins/tauri-plugin-hardware/src/vendor/vulkan.rs which does not depend on jan_utils. The jan_utils version had zero external callers.
Risks: None. Pure dead-code removal.
Style: Clean deletion, no leftover references.
Tests: The three tests covering the removed function are also deleted. Remaining tests in the module are unaffected.
Summary: This PR removes the unused parse_uuid function and its three test cases from src-tauri/utils/src/string.rs. The only other parse_uuid in the repo is a private copy in the hardware plugin's vulkan module, which does not depend on jan_utils.
Findings:
The removal is clean: one function and three tests deleted.
No external callers exist for jan_utils::string::parse_uuid -- confirmed dead code.
The hardware plugin's private copy is independent and unaffected.
Summary: Removes the parse_uuid function and its three test cases from src-tauri/utils/src/string.rs. The function had no external callers -- the only other parse_uuid in the codebase is a private copy in the Vulkan hardware plugin that does not depend on jan_utils.
Positive observations
Pure deletion of dead code with no behavioral impact.
The PR description correctly identifies the private copy in the hardware plugin and explains why unification is not in scope.
Verified with cargo check and cargo test.
Issues and observations
None. This is a clean removal of unused code. The diff is straightforward: -39 lines, 0 additions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
parse_uuidhelper and its threetest_parse_uuid*cases fromsrc-tauri/utils/src/string.rs.jan_utils::string::parse_uuidhad no external callers. The only otherparse_uuidin the repo lives atsrc-tauri/plugins/tauri-plugin-hardware/src/vendor/vulkan.rsas a private function — the hardware plugin does not depend onjan_utils, so it cannot use the shared version.cargo check -p jan-utilsandcargo test --lib(33 passed) insidesrc-tauri/utils.Fixes Issues
Self Checklist