Skip to content

chore: remove unused jan_utils::string::parse_uuid#8077

Open
since-2017-hub wants to merge 1 commit into
janhq:mainfrom
since-2017-hub:chore/remove-unused-parse-uuid
Open

chore: remove unused jan_utils::string::parse_uuid#8077
since-2017-hub wants to merge 1 commit into
janhq:mainfrom
since-2017-hub:chore/remove-unused-parse-uuid

Conversation

@since-2017-hub
Copy link
Copy Markdown
Contributor

Describe Your Changes

  • Remove the unused parse_uuid helper and its three test_parse_uuid* cases from src-tauri/utils/src/string.rs.
  • jan_utils::string::parse_uuid had no external callers. The only other parse_uuid in the repo lives at src-tauri/plugins/tauri-plugin-hardware/src/vendor/vulkan.rs as a private function — the hardware plugin does not depend on jan_utils, so it cannot use the shared version.
  • Verified with cargo check -p jan-utils and cargo test --lib (33 passed) inside src-tauri/utils.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@tokamak-pm
Copy link
Copy Markdown

tokamak-pm Bot commented Apr 24, 2026

Review: remove unused jan_utils::string::parse_uuid

Summary: Removes the parse_uuid function and its three associated tests (test_parse_uuid, test_parse_uuid_zeros, test_parse_uuid_max_values) from src-tauri/utils/src/string.rs. Total: -39 lines, 0 additions.

Findings:

  • Correctness: Verified -- the only other parse_uuid in the repo is a private function in src-tauri/plugins/tauri-plugin-hardware/src/vendor/vulkan.rs which does not depend on jan_utils. The jan_utils version had zero external callers.
  • Risks: None. Pure dead-code removal.
  • Style: Clean deletion, no leftover references.
  • Tests: The three tests covering the removed function are also deleted. Remaining tests in the module are unaffected.

Recommendation: can merge

@tokamak-pm
Copy link
Copy Markdown

tokamak-pm Bot commented Apr 26, 2026

Code Review

Summary: This PR removes the unused parse_uuid function and its three test cases from src-tauri/utils/src/string.rs. The only other parse_uuid in the repo is a private copy in the hardware plugin's vulkan module, which does not depend on jan_utils.

Findings:

  • The removal is clean: one function and three tests deleted.
  • No external callers exist for jan_utils::string::parse_uuid -- confirmed dead code.
  • The hardware plugin's private copy is independent and unaffected.
  • No compile or runtime behavioral changes.
  • Note: This PR will conflict with PR chore: remove unused jan_utils::string::parse_c_string helper #8073 (which also removes parse_c_string from the same file). Whichever merges second will need a trivial rebase. Not a blocker, but worth coordinating merge order.

Recommendation: Can merge. Straightforward dead-code removal with no risk.

@tokamak-pm
Copy link
Copy Markdown

tokamak-pm Bot commented May 1, 2026

Review: chore: remove unused jan_utils::string::parse_uuid

Summary: Removes the parse_uuid function and its three test cases from src-tauri/utils/src/string.rs. The function had no external callers -- the only other parse_uuid in the codebase is a private copy in the Vulkan hardware plugin that does not depend on jan_utils.

Positive observations

  • Pure deletion of dead code with no behavioral impact.
  • The PR description correctly identifies the private copy in the hardware plugin and explains why unification is not in scope.
  • Verified with cargo check and cargo test.

Issues and observations

  • None. This is a clean removal of unused code. The diff is straightforward: -39 lines, 0 additions.

Recommendation: can merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

chore: remove unused jan_utils::string::parse_uuid (hardware plugin has its own copy)

1 participant