Skip to content

Drop re_path from installation guide #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Drop re_path from installation guide #1435

merged 1 commit into from
Jun 20, 2024

Conversation

jaap3
Copy link

@jaap3 jaap3 commented Jun 20, 2024

Description of the Change

Removed the bit about using re_path to add urls. It's just confusing, as a user I don't know why I should pick this option over the first one.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@jaap3
Copy link
Author

jaap3 commented Jun 20, 2024

Just a note, including the urls like this:

from oauth2_provider import urls as oauth2_urls

urlpatterns = [
    path("o/", include(oauth2_urls))
]

works just as well, and removes the need to set a namespace (app_name in the urls module does the job).

Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the change you mentioned in your comment since keeping things simple is best:

from oauth2_provider import urls as oauth2_urls

urlpatterns = [
    path("o/", include(oauth2_urls))
]

@jaap3 jaap3 mentioned this pull request Jun 20, 2024
5 tasks
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #1436 for more

@n2ygk n2ygk merged commit 924310b into jazzband:master Jun 20, 2024
27 checks passed
@jaap3 jaap3 deleted the patch-2 branch June 21, 2024 17:37
@n2ygk n2ygk added this to the 3.0.0 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants