Skip to content

Simplify urlpattern loading #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

jaap3
Copy link

@jaap3 jaap3 commented Jun 20, 2024

Description of the Change

Simplify how urlpatterns are loaded, as requested in #1435 (review)

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@jaap3
Copy link
Author

jaap3 commented Jun 20, 2024

@n2ygk as requested, here's a PR that changes how the urlpatterns are loaded. I've also updated how they are loaded in tests, to verify that it works.

This branch is based on PR #1435.

I didn't want to update that PR, because this change is somewhat more involved than just a minor docs tweak.

I'll rebase this one when the base branch merges.

[EDIT]: Not sure why the readthedocs build has failed? Doesn't seem related to the changes.

@n2ygk n2ygk mentioned this pull request Jun 20, 2024
5 tasks
@jaap3 jaap3 force-pushed the simplify-urlpattern-loading branch from ef53ad7 to 2880504 Compare June 21, 2024 11:11
@jaap3 jaap3 marked this pull request as ready for review June 21, 2024 11:11
@jaap3 jaap3 force-pushed the simplify-urlpattern-loading branch from 2880504 to 6db4346 Compare June 21, 2024 11:13
Copy link
Member

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and DRY. Thanks! Please add yourself to AUTHORS.

@jaap3 jaap3 force-pushed the simplify-urlpattern-loading branch from 6db4346 to bfc77ff Compare June 21, 2024 16:11
@jaap3 jaap3 requested a review from n2ygk June 21, 2024 16:12
@n2ygk n2ygk merged commit 9cb93ee into jazzband:master Jun 21, 2024
27 checks passed
@jaap3 jaap3 deleted the simplify-urlpattern-loading branch June 21, 2024 17:36
@n2ygk n2ygk added this to the 3.0.0 milestone Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants