feat: Implement #9: Show Jeddict icon in NetBeans menus#166
Merged
Conversation
This commit implements the user story from issue #9, allowing Jeddict icons to be displayed before menu items in NetBeans, enhancing visibility and usability. As part of this feature, significant refactoring was undertaken to improve code quality and maintainability: - Introduced `BaseGitAction` to centralize Git project-related action logic. - Introduced `BaseContextAction` for common context-aware action functionalities. - Introduced `BaseProjectContextAction` for project-specific context actions. - Refactored `GenerateCommitMessageAction` and `ReviewAction` to leverage these new base classes. - Added comprehensive Javadoc to all classes within the `io.github.jeddict.ai.actions` package for improved code documentation.
jGauravGupta
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the user story from issue #9, allowing Jeddict icons to be displayed before menu items in NetBeans, enhancing visibility and usability.
As part of this feature, significant refactoring was undertaken to improve code quality and maintainability:
BaseGitActionto centralize Git project-related action logic.BaseContextActionfor common context-aware action functionalities.BaseProjectContextActionfor project-specific context actions.GenerateCommitMessageActionandReviewActionto leverage these new base classes.io.github.jeddict.ai.actionspackage for improved code documentation.The implementation is a bit tricky as the most immediate method by setting a baseIcon does not actually work out of the box. The core of the implementation is to implement the interface Presenter.Popup, basically setting the icon programmatically and creating a new JMenuItem. The rest of the changes are to reduce code duplication and to improve JavaDoc.