Skip to content

Fix Roku subtitle menu for burned-in tracks #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1hitsong merged 4 commits into from
May 10, 2026
+5 −2
Merged

Fix Roku subtitle menu for burned-in tracks #854

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebbc0f8
Fix Roku subtitle menu for burned-in tracks
VX-101 Apr 30, 2026
9d74f07
Merge branch 'master' into fix-subtitle-burnin-selection
jimdogx Apr 30, 2026
d3d2021
Merge branch 'master' into fix-subtitle-burnin-selection
VX-101 May 10, 2026
800070b
Update What's New
VX-101 May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions components/video/VideoPlayerView.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,7 +803,6 @@ sub onVideoContentLoaded()

if subtitle.Index = videoContent[0].selectedSubtitle
selectedSubtitle = subtitle
exit for
end if
end for

Expand All @@ -826,9 +825,7 @@ sub onVideoContentLoaded()
end if
end if

if not (m.isTranscoded and burnInSubtitles)
m.top.selectedSubtitle = videoContent[0].selectedSubtitle
end if
m.top.selectedSubtitle = videoContent[0].selectedSubtitle

m.top.observeField("selectedSubtitle", "onSubtitleChange")

Expand Down