Fix Roku subtitle menu for burned-in tracks#854
Open
VX-101 wants to merge 2 commits intojellyfin:masterfrom
Open
Fix Roku subtitle menu for burned-in tracks#854VX-101 wants to merge 2 commits intojellyfin:masterfrom
VX-101 wants to merge 2 commits intojellyfin:masterfrom
Conversation
jimdogx
approved these changes
Apr 30, 2026
Member
|
Don't forget to update Whats New if you'd like credit for your work. |
1hitsong
approved these changes
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the in-playback subtitle menu state when playback is transcoding with burned-in subtitles.
When burn-in subtitles were enabled,
onVideoContentLoaded()marked subtitle tracks as encoded but stopped iterating after finding the selected track. That meant any later subtitle tracks were dropped fromfullSubtitleData, so the playback subtitle menu could show an incomplete list.The player also skipped updating
selectedSubtitleduring burned-in subtitle playback, so the menu could showNoneeven though Jellyfin had selected and burned in a default subtitle stream.This change:
selectedSubtitlewhile the observer is temporarily removedFixes #851.
Testing
npm run buildsuccessfully.Noneplus both PGS tracks.