Show subtitle track info on the item details screen.#857
Open
VX-101 wants to merge 4 commits intojellyfin:masterfrom
Open
Show subtitle track info on the item details screen.#857VX-101 wants to merge 4 commits intojellyfin:masterfrom
VX-101 wants to merge 4 commits intojellyfin:masterfrom
Conversation
Author
|
I saw PR #728, but it was opened back on February 9 and still has not been merged. My changes are small and localized, so I believe they can be reviewed and merged independently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
+Nfor additional subtitle streams.No Defaultwhen subtitle streams exist and none is marked default.Optionssubtitle list when no subtitle preference has been selected.Testing
npm run buildsuccessfully.Optionssubtitle checkmark for default and no-default subtitle cases.Known issue
Noneis selected, but a subtitle track is still shown. (see FixNonesubtitle playback selection after #854. #868 for the fix)