Skip to content

Show subtitle track info on the item details screen.#857

Open
VX-101 wants to merge 4 commits intojellyfin:masterfrom
VX-101:fix-info-subtitle-tracks
Open

Show subtitle track info on the item details screen.#857
VX-101 wants to merge 4 commits intojellyfin:masterfrom
VX-101:fix-info-subtitle-tracks

Conversation

@VX-101
Copy link
Copy Markdown

@VX-101 VX-101 commented Apr 30, 2026

Summary

  • Add a subtitle info row below the existing video and audio rows on the item details screen.
  • Display the default subtitle stream when one is available, with +N for additional subtitle streams.
  • Display No Default when subtitle streams exist and none is marked default.
  • Show the Jellyfin default subtitle track as checked in the details Options subtitle list when no subtitle preference has been selected.

Testing

  • Ran npm run build successfully.
  • Sideloaded the generated Roku package.
  • Tested locally with generated media clips covering default, no-default, forced internal text, external SRT, no-subtitle, single-subtitle, and forced-default subtitle cases.
  • Compared the Roku subtitle info row with Jellyfin subtitle metadata.
  • Verified the details Options subtitle checkmark for default and no-default subtitle cases.

Known issue

@VX-101 VX-101 requested a review from a team as a code owner April 30, 2026 23:51
@VX-101 VX-101 changed the title Show subtitle info on item details Show subtitle information on the item details screen. May 1, 2026
@VX-101
Copy link
Copy Markdown
Author

VX-101 commented May 1, 2026

I saw PR #728, but it was opened back on February 9 and still has not been merged. My changes are small and localized, so I believe they can be reviewed and merged independently.
@1hitsong Please take a look. This PR, together with PR #858, resolves issues related to displaying default/selected subtitles. See #868

@VX-101 VX-101 changed the title Show subtitle information on the item details screen. Show subtitle track info on the item details screen. May 2, 2026
@VX-101 VX-101 marked this pull request as draft May 2, 2026 19:43
@VX-101 VX-101 marked this pull request as ready for review May 2, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant