Fix None subtitle playback selection after #854. #868
Draft
VX-101 wants to merge 3 commits intojellyfin:masterfrom
Draft
Fix None subtitle playback selection after #854. #868VX-101 wants to merge 3 commits intojellyfin:masterfrom
None subtitle playback selection after #854. #868VX-101 wants to merge 3 commits intojellyfin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a previously hidden Roku caption-mode issue exposed by #854.
After #854, pre-playback subtitle selection can pass
SubtitleSelection.NONEinto playback. However, Roku’s native caption renderer could still remainOn, allowing subtitles to display even thoughNonewas selected.This change turns Roku caption mode off and clears the active subtitle track when playback starts with
SubtitleSelection.NONE.Related PRs
Noneis explicitly selected.Testing
WIP