[UI] Return a warning message when results have not been found (Identify View) #7423
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Cloudflare Pages deployment
|
dmitrylyzo
reviewed
Dec 13, 2025
| showIdentificationSearchResults(page, results); | ||
| if (results.length > 0) { | ||
| //Ensure we have results | ||
| loading.hide(); |
Contributor
There was a problem hiding this comment.
Move loading.hide() to where it was.
| showIdentificationSearchResults(page, results); | ||
| } else { | ||
| // Show not found message | ||
| loading.hide(); |
| <div class="identifyProviderIds"></div> | ||
|
|
||
| <div> | ||
| <p style="display:flex; align-items:center" id="identifyNotFoundMessage" class="hide"><span class="material-icons warning" aria-hidden="true" style="margin-right:5px"></span>${IdentifyResultNotFound}</p> |
Contributor
There was a problem hiding this comment.
Extract the inline style as #identifyNotFoundMessage (or add a new class for messages). I think we should create a new file (itemidentifier.scss) for this.
src/strings/en-us.json
Outdated
| "LabelExtractTrickplayDuringLibraryScanHelp": "Generate trickplay images when videos are imported during the library scan. Otherwise, they will be extracted during the trickplay images scheduled task. If generation is set to non-blocking this will not affect the time a library scan takes to complete.", | ||
| "LogLoadFailure": "Failed to load the log file. It may still be actively written to." | ||
| "LogLoadFailure": "Failed to load the log file. It may still be actively written to.", | ||
| "IdentifyResultNotFound": "No results found. Try different parameters." |
Contributor
There was a problem hiding this comment.
I recommend adding new values in alphabetical order. In this case, there will be less chance of conflicts. Don't look that the file is currently unordered (at the end), just move the line up (starting from the beginning).
Also, maybe add a Message prefix to the string identifier?
… order. Create a new .scss file for itemidentifier and extract inline clases. Change id from identifyResultNotFound to messageIdentifyResultNotFound. Move .hide() where it was before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If trying to identify an item and search doesn't return results, show the message
Issues
Fixes #7365