Skip to content

[UI] Return a warning message when results have not been found (Identify View) #7423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uxdesignerhector wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[UI] Return a warning message when results have not been found (Identify View) #7423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
777aa99
Return a warning message when results have not been found. Solves htt…
uxdesignerhector Dec 12, 2025
1dce71e
Prefix IdentifyResultNotFound with Message and put it in alphabetical…
uxdesignerhector Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/components/itemidentifier/itemidentifier.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import '../cardbuilder/card.scss';
import toast from '../toast/toast';
import template from './itemidentifier.template.html';
import datetime from '../../scripts/datetime';
import './itemidentifier.scss';

const enableFocusTransform = !browser.slow && !browser.edge;

Expand Down Expand Up @@ -98,7 +99,13 @@ function searchForIdentificationResults(page) {

}).then(results => {
loading.hide();
showIdentificationSearchResults(page, results);
if (results.length > 0) {
//Ensure we have results
showIdentificationSearchResults(page, results);
} else {
// Show not found message
page.querySelector('#messageIdentifyResultNotFound').classList.remove('hide');
}
});
}

Expand Down
8 changes: 8 additions & 0 deletions src/components/itemidentifier/itemidentifier.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#messageIdentifyResultNotFound {
display: flex;
align-items: center;

.material-icons {
margin-right: 5px;
}
}
4 changes: 4 additions & 0 deletions src/components/itemidentifier/itemidentifier.template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ <h3 class="formDialogHeaderTitle">${Identify}</h3>

<div class="identifyProviderIds"></div>

<div>
<p id="messageIdentifyResultNotFound" class="hide"><span class="material-icons warning" aria-hidden="true"></span>${MessageIdentifyResultNotFound}</p>
</div>

<div class="formDialogFooter">
<button is="emby-button" type="submit" class="raised button-submit block formDialogFooterItem">
<span>${Search}</span>
Expand Down
1 change: 1 addition & 0 deletions src/strings/en-us.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,6 +1150,7 @@
"MessageForgotPasswordPinReset": "Enter PIN here to finish Password reset",
"MessageForgotPasswordInNetworkRequired": "Please try again within your home network to initiate the password reset process.",
"MessageGetInstalledPluginsError": "An error occurred while getting the list of currently installed plugins.",
"MessageIdentifyResultNotFound": "No results found. Try different parameters.",
"MessageImageFileTypeAllowed": "Only JPEG and PNG files are supported.",
"MessageImageTypeNotSelected": "Please select an image type from the drop-down menu.",
"MessageInvalidForgotPasswordPin": "An invalid or expired PIN code was entered. Please try again.",
Expand Down
Loading