Refactor buffer length calculation for HLS player #7455
+7
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated max buffer length calculation based on bitrate and added clamping between 6s and 60s. Removed hardcoded buffer length limits for specific browsers.
Collaborator
Cloudflare Pages deployment
|
|
Author
|
Based on observations, the modified network resources are now being utilized more efficiently. The previous 6-second limitation caused bubbles in the buffering process, resulting in the network being idle or restricted approximately 20% of the time. This means that after the modification, the player's requirements for the network environment will be reduced to some extent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated max buffer length calculation based on bitrate and added clamping between 6s and 60s. Removed hardcoded buffer length limits for specific browsers.
Changes
Updated max buffer length calculation based on bitrate and added clamping between 6s and 60s. Removed hardcoded buffer length limits for specific browsers.
Issues
Fix #5246
Fix #15787