Skip to content

Refactor buffer length calculation for HLS player #7455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AinzRimuru wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor buffer length calculation for HLS player #7455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
787301b
Refactor buffer length calculation for HLS player
AinzRimuru Dec 29, 2025
fcfb5cf
Merge branch 'jellyfin:master' into master
AinzRimuru Dec 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/plugins/htmlVideoPlayer/plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,15 +440,13 @@ export class HtmlVideoPlayer {
setSrcWithHlsJs(elem, options, url) {
return new Promise((resolve, reject) => {
requireHlsPlayer(async () => {
let maxBufferLength = 30;

// Some browsers cannot handle huge fragments in high bitrate.
// This issue usually happens when using HWA encoders with a high bitrate setting.
// Limit the BufferLength to 6s, it works fine when playing 4k 120Mbps over HLS on chrome.
// https://github.com/video-dev/hls.js/issues/876
if ((browser.chrome || browser.edgeChromium || browser.firefox) && playbackManager.getMaxStreamingBitrate(this) >= 25000000) {
maxBufferLength = 6;
}
// Dynamic buffer length based on bitrate
// Limit max buffer size to 50MB (50 * 1024 * 1024 * 8 bits = 419430400 bits)
const maxBufferSizeBits = 50 * 1024 * 1024 * 8;
const bitrate = playbackManager.getMaxStreamingBitrate(this) || 8000000; // Default 8Mbps
let maxBufferLength = Math.floor(maxBufferSizeBits / bitrate);
// Clamp buffer length between 6s and 60s
maxBufferLength = Math.max(6, Math.min(60, maxBufferLength));

const includeCorsCredentials = await getIncludeCorsCredentials();

Expand Down
Loading