-
Notifications
You must be signed in to change notification settings - Fork 192
Add LlvmLinkerParser for LLVM lld linker error parsing #1245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LlvmLinkerParser for LLVM lld linker error parsing #1245
Conversation
- Add LlvmLinkerParser class for parsing ld.lld error messages - Support versioned linkers (ld.lld-15, etc.) - Handle error/warning/note severity levels - Integrate with ClangDescriptor using composite pattern - Add comprehensive unit and integration tests Resolves JENKINS-76141
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your pull request! Just some small comments...
src/main/java/edu/hm/hafner/analysis/parser/LlvmLinkerParser.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/hm/hafner/analysis/parser/LlvmLinkerParser.java
Outdated
Show resolved
Hide resolved
src/test/java/edu/hm/hafner/analysis/parser/LlvmLinkerParserTest.java
Outdated
Show resolved
Hide resolved
src/test/java/edu/hm/hafner/analysis/parser/LlvmLinkerParserTest.java
Outdated
Show resolved
Hide resolved
|
@sgscheffler ping: I'm not sure if you have enabled your notifications... |
|
Regex now uses named groups (linker, severity, message); Author tags fixed; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine now, thanks!
Can you please have a look at the indention? There are two CheckStyle warnings.
Summary
Add LlvmLinkerParser for LLVM lld linker error parsing
Changes
Resolves JENKINS-76141
Testing Done
Unit Tests
LlvmLinkerParserTestwith 7 test methods covering:Integration Tests
shouldFindAllClangAndLldIssuesto ParsersTestManual Testing
mvn clean testpassesVerification
Submitter Checklist